fix: nytimes custom parser title selector (#181)

* fix: nytimes custom parser title selector

* upgrade node version

* circle ci tweak

Author: adampash

circle.yml

@@ -5,13 +5,14 @@ machine:
 
   node:
     version:
-      4.3.2
+      6.10
 
 ## Customize dependencies
 dependencies:
   pre:
     - curl -o- -L https://yarnpkg.com/install.sh | bash
     - nvm install 7.0.0
+    - nvm install 6.10.0
     # For some reason phantomjs-prebuild is failing w/yarn, but npm installing works
     - npm install phantomjs-prebuilt
 
@@ -29,5 +30,5 @@ test:
     - nvm use 7.0 && yarn test:web -- --maxWorkers=4 && yarn build:web -- --maxWorkers=4:
         parallel: true
     # Switch to check on 4.3.2
-    - nvm use 4.3.2 && yarn build && yarn test:node -- --maxWorkers=4:
+    - nvm use 6.10 && yarn build && yarn test:node -- --maxWorkers=4:
         parallel: true

fixtures/www.nytimes.com/1539194812689.html

@@ -3,7 +3,8 @@ export const NYTimesExtractor = {
 
   title: {
     selectors: [
-      '.g-headline',
+      'h1.g-headline',
+      'h1[itemprop="headline"]',
       'h1.headline',
     ],
   },

src/extractors/custom/www.nytimes.com/index.js

@@ -102,4 +102,13 @@ describe('NYTimesExtractor', () => {
     assert.equal(author, 'The New York Times');
     assert.equal(text, 'T he Smithsonian’s N');
   });
+
+  it('returns the title on most recent articles', async () => {
+    const html = fs.readFileSync('./fixtures/www.nytimes.com/1539194812689.html');
+    const uri = 'https://www.nytimes.com/2018/10/09/us/politics/nikki-haley-united-nations.html';
+
+    const { title } = await Mercury.parse(uri, html);
+
+    assert.equal(title, 'Nikki Haley to Resign as Trump’s Ambassador to the U.N.');
+  });
 });