Run tests with accounts cache cleaning (anza-xyz#10093)

Author: roryharr

accounts-db/benches/accounts.rs

@@ -86,10 +86,7 @@ where
     .collect();
     let storable_accounts: Vec<_> = pubkeys.iter().zip(accounts_data.iter()).collect();
     accounts.store_accounts_par((slot, storable_accounts.as_slice()), None);
-    accounts.add_root(slot);
-    accounts
-        .accounts_db
-        .flush_accounts_cache_slot_for_tests(slot);
+    accounts.accounts_db.add_root_and_flush_write_cache(slot);
 
     let pubkeys = Arc::new(pubkeys);
     for i in 0..num_readers {

runtime/src/bank.rs

@@ -6043,14 +6043,6 @@ impl Bank {
         self.try_process_entry_transactions(txs).unwrap()
     }
 
-    #[cfg(test)]
-    pub fn flush_accounts_cache_slot_for_tests(&self) {
-        self.rc
-            .accounts
-            .accounts_db
-            .flush_accounts_cache_slot_for_tests(self.slot())
-    }
-
     pub fn get_sysvar_cache_for_tests(&self) -> SysvarCache {
         self.transaction_processor.get_sysvar_cache_for_tests()
     }

runtime/src/bank/serde_snapshot.rs

@@ -174,7 +174,7 @@ mod tests {
 
     fn add_root_and_flush_write_cache(bank: &Bank) {
         bank.rc.accounts.add_root(bank.slot());
-        bank.flush_accounts_cache_slot_for_tests()
+        bank.force_flush_accounts_cache();
     }
 
     #[test_case(#[allow(deprecated)] StorageAccess::Mmap)]

runtime/src/bank/tests.rs

@@ -5718,7 +5718,7 @@ fn test_add_builtin_account() {
 /// to use the write cache
 fn add_root_and_flush_write_cache(bank: &Bank) {
     bank.rc.accounts.add_root(bank.slot());
-    bank.flush_accounts_cache_slot_for_tests()
+    bank.force_flush_accounts_cache();
 }
 
 #[test]