From d8a955fd39f57cb10acbc2975c456d0a33fb00e5 Mon Sep 17 00:00:00 2001 From: Gold856 <117957790+Gold856@users.noreply.github.com> Date: Sun, 25 Jan 2026 06:25:30 -0500 Subject: [PATCH 1/3] Update PR template --- .github/pull_request_template.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 704a41b1ac..6c491fbb9c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,18 +1,18 @@ ## Description - +What changed? Why? (the code + comments should speak for itself on the "how") - +Fun screenshots or a cool video or something are super helpful as well. If this touches core/platform-specific behavior, this is where test evidence should be collected. Test evidence is important to establish feature functionality. - +Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. ## Meta Merge checklist: - [ ] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes -- [ ] The description documents the _what_ and _why_ +- [ ] The description documents the _what_ and _why_, including events that led to this PR - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly -- [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 +- [ ] If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends) - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added From 71505cd63326fd6d7427ae264801531e5dbdb140 Mon Sep 17 00:00:00 2001 From: Gold856 <117957790+Gold856@users.noreply.github.com> Date: Sun, 25 Jan 2026 23:47:50 -0500 Subject: [PATCH 2/3] Update .github/pull_request_template.md Co-authored-by: Matt Morley --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6c491fbb9c..b5252eaa9a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ What changed? Why? (the code + comments should speak for itself on the "how") -Fun screenshots or a cool video or something are super helpful as well. If this touches core/platform-specific behavior, this is where test evidence should be collected. Test evidence is important to establish feature functionality. +Include fun testing screenshots or a cool video, to collect test evidence in a place where we can later reference it. Including proof this change was tested makes reviewing easier, helps us make sure we tested all our edge cases, and helps provide context for the future. Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. From 4b7c4b79c5cdf1ce8abae6b34247adc49ca06ed0 Mon Sep 17 00:00:00 2001 From: samfreund Date: Sun, 25 Jan 2026 23:29:31 -0600 Subject: [PATCH 3/3] lint --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b5252eaa9a..0237d645a6 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ What changed? Why? (the code + comments should speak for itself on the "how") -Include fun testing screenshots or a cool video, to collect test evidence in a place where we can later reference it. Including proof this change was tested makes reviewing easier, helps us make sure we tested all our edge cases, and helps provide context for the future. +Include fun testing screenshots or a cool video, to collect test evidence in a place where we can later reference it. Including proof this change was tested makes reviewing easier, helps us make sure we tested all our edge cases, and helps provide context for the future. Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`.