fix floating promises

Author: samfreund

photon-client/src/components/app/photon-3d-visualizer.vue

@@ -151,7 +151,7 @@ const resetCamThirdPerson = () => {
 };
 
 // async for lazy loading
-// eslint-disable-next-line @typescript-eslint/require-await
+ 
 onMounted(async () => {
   scene = new Scene();
   camera = new PerspectiveCamera(75, 800 / 800, 0.1, 1000);
@@ -215,7 +215,7 @@ onMounted(async () => {
     renderer.render(scene, camera);
   };
 
-  drawTargets(props.targets);
+  await drawTargets(props.targets);
   animate();
 });
 onBeforeUnmount(() => {

photon-client/src/components/app/photon-calibration-visualizer.vue

@@ -202,10 +202,10 @@ const resetCamThirdPerson = () => {
 let animationFrameId: number | null = null;
 
 // async for lazy loading
-// eslint-disable-next-line @typescript-eslint/require-await
+ 
 onMounted(async () => {
   // Grab data first off
-  fetchCalibrationData();
+  await fetchCalibrationData();
 
   scene = new Scene();
   camera = new PerspectiveCamera(75, 800 / 800, 0.1, 1000);
@@ -329,7 +329,7 @@ if (import.meta.hot) {
 }
 
 watchEffect(() => {
-  drawCalibration(calibrationData.value);
+  void drawCalibration(calibrationData.value);
 });
 
 watch(
@@ -339,9 +339,9 @@ watch(
     props.resolution.height,
     useCameraSettingsStore().getCalibrationCoeffs(props.resolution)
   ],
-  () => {
+  async () => {
     console.log("Camera or resolution changed, refetching calibration");
-    fetchCalibrationData();
+    await fetchCalibrationData();
   }
 );
 </script>

photon-client/src/components/app/photon-camera-stream.vue

@@ -68,10 +68,10 @@ const handleCaptureClick = () => {
 const handlePopoutClick = () => {
   window.open(streamSrc.value);
 };
-const handleFullscreenRequest = () => {
+const handleFullscreenRequest = async () => {
   const stream = document.getElementById(props.id);
   if (!stream) return;
-  stream.requestFullscreen();
+  await stream.requestFullscreen();
 };
 
 const mjpgStream = ref<HTMLImageElement | null>(null);

photon-client/src/components/cameras/CameraCalibrationInfoCard.vue

@@ -15,8 +15,8 @@ const props = defineProps<{
 
 const confirmRemoveDialog = ref({ show: false, vf: props.videoFormat });
 
-const removeCalibration = (vf: VideoFormat) => {
-  axiosPost("/calibration/remove", "delete a camera calibration", {
+const removeCalibration = async (vf: VideoFormat) => {
+  await axiosPost("/calibration/remove", "delete a camera calibration", {
     cameraUniqueName: useCameraSettingsStore().currentCameraSettings.uniqueName,
     width: vf.resolution.width,
     height: vf.resolution.height

photon-client/src/components/cameras/CameraSettingsCard.vue

@@ -123,8 +123,8 @@ watchEffect(() => {
 });
 
 const showDeleteCamera = ref(false);
-const deleteThisCamera = () => {
-  axiosPost("/utils/nukeOneCamera", "delete this camera", {
+const deleteThisCamera = async () => {
+  await axiosPost("/utils/nukeOneCamera", "delete this camera", {
     cameraUniqueName: useStateStore().currentCameraUniqueName
   });
 };

photon-client/src/components/settings/DeviceCard.vue

@@ -15,12 +15,12 @@ const theme = useTheme();
 
 const restartProgram = async () => {
   if (await axiosPost("/utils/restartProgram", "restart PhotonVision")) {
-    forceReloadPage();
+    await forceReloadPage();
   }
 };
 const restartDevice = async () => {
   if (await axiosPost("/utils/restartDevice", "restart the device")) {
-    forceReloadPage();
+    await forceReloadPage();
   }
 };
 
@@ -36,7 +36,7 @@ const majorVersionRegex = new RegExp("(?:dev-)?(\\d+)\\.\\d+\\.\\d+");
 
 const offlineUpdateDialog = ref({ show: false, confirmString: "" });
 
-const handleOfflineUpdateRequest = () => {
+const handleOfflineUpdateRequest = async () => {
   const files = offlineUpdate.value?.files;
   if (!files) return;
   if (files.length === 0) return;
@@ -69,7 +69,7 @@ const handleOfflineUpdateRequest = () => {
     });
     return;
   } else if (versionMatch && !dev) {
-    handleOfflineUpdate(files[0]);
+    await handleOfflineUpdate(files[0]);
   } else if (!versionMatch && !dev) {
     offlineUpdateDialog.value = {
       show: true,
@@ -119,7 +119,7 @@ const handleOfflineUpdate = async (file: File) => {
       color: "secondary",
       timeout: -1
     });
-    forceReloadPage();
+    await forceReloadPage();
   }
 };
 
@@ -145,7 +145,7 @@ const showImportDialog = ref(false);
 const importType = ref<ImportType | undefined>(undefined);
 const importFile = ref<File | null>(null);
 
-const handleSettingsImport = () => {
+const handleSettingsImport = async () => {
   if (importType.value === undefined || importFile.value === null) return;
   const formData = new FormData();
   formData.append("data", importFile.value);
@@ -168,7 +168,7 @@ const handleSettingsImport = () => {
       settingsEndpoint = "";
       break;
   }
-  axiosPost(`/settings${settingsEndpoint}`, "import settings", formData, {
+  await axiosPost(`/settings${settingsEndpoint}`, "import settings", formData, {
     headers: { "Content-Type": "multipart/form-data" }
   });
   showImportDialog.value = false;
@@ -179,7 +179,7 @@ const handleSettingsImport = () => {
 const showFactoryReset = ref(false);
 const nukePhotonConfigDirectory = async () => {
   if (await axiosPost("/utils/nukeConfigDirectory", "delete the config directory")) {
-    forceReloadPage();
+    await forceReloadPage();
   }
 };
 

photon-client/src/components/settings/ObjectDetectionCard.vue

@@ -74,20 +74,20 @@ const handleImport = async () => {
   importVersion.value = null;
 };
 
-const deleteModel = (model: ObjectDetectionModelProperties) => {
-  axiosPost("/objectdetection/delete", "delete an object detection model", {
+const deleteModel = async (model: ObjectDetectionModelProperties) => {
+  await axiosPost("/objectdetection/delete", "delete an object detection model", {
     modelPath: model.modelPath
   });
 };
 
-const renameModel = (model: ObjectDetectionModelProperties, newName: string) => {
+const renameModel = async (model: ObjectDetectionModelProperties, newName: string) => {
   useStateStore().showSnackbarMessage({
     message: "Renaming Object Detection Model...",
     color: "secondary",
     timeout: -1
   });
 
-  axiosPost("/objectdetection/rename", "rename an object detection model", {
+  await axiosPost("/objectdetection/rename", "rename an object detection model", {
     modelPath: model.modelPath,
     newName: newName
   });
@@ -117,8 +117,8 @@ const openExportIndividualModelPrompt = () => {
 };
 
 const showNukeDialog = ref(false);
-const nukeModels = () => {
-  axiosPost("/objectdetection/nuke", "clear and reset object detection models");
+const nukeModels = async () => {
+  await axiosPost("/objectdetection/nuke", "clear and reset object detection models");
 };
 
 const showBulkImportDialog = ref(false);

photon-client/src/plugins/vuetify.ts

@@ -1,5 +1,5 @@
 import "vuetify/styles";
-import("@mdi/font/css/materialdesignicons.css");
+import "@mdi/font/css/materialdesignicons.css";
 import type { ThemeDefinition } from "vuetify";
 import { createVuetify } from "vuetify";
 

photon-client/src/views/CameraMatchingView.vue

@@ -16,45 +16,45 @@ const backendHostname = inject<string>("backendHostname", "localhost");
 const formatUrl = (port: number) => `http://${backendHostname}:${port}/stream.mjpg`;
 
 const activatingModule = ref(false);
-const activateModule = (moduleUniqueName: string) => {
+const activateModule = async (moduleUniqueName: string) => {
   if (activatingModule.value) return;
   activatingModule.value = true;
 
-  axiosPost("/utils/activateMatchedCamera", "activate a matched camera", {
+  await axiosPost("/utils/activateMatchedCamera", "activate a matched camera", {
     cameraUniqueName: moduleUniqueName
   }).finally(() => (activatingModule.value = false));
 };
 
 const assigningCamera = ref(false);
-const assignCamera = (cameraInfo: PVCameraInfo) => {
+const assignCamera = async (cameraInfo: PVCameraInfo) => {
   if (assigningCamera.value) return;
   assigningCamera.value = true;
 
   const payload = {
     cameraInfo: cameraInfo
   };
 
-  axiosPost("/utils/assignUnmatchedCamera", "assign an unmatched camera", payload).finally(
+  await axiosPost("/utils/assignUnmatchedCamera", "assign an unmatched camera", payload).finally(
     () => (assigningCamera.value = false)
   );
 };
 
 const deactivatingModule = ref(false);
-const deactivateModule = (cameraUniqueName: string) => {
+const deactivateModule = async (cameraUniqueName: string) => {
   if (deactivatingModule.value) return;
   deactivatingModule.value = true;
-  axiosPost("/utils/unassignCamera", "unassign a camera", { cameraUniqueName: cameraUniqueName }).finally(
+  await axiosPost("/utils/unassignCamera", "unassign a camera", { cameraUniqueName: cameraUniqueName }).finally(
     () => (deactivatingModule.value = false)
   );
 };
 
 const confirmDeleteDialog = ref({ show: false, nickname: "", cameraUniqueName: "" });
 const deletingCamera = ref<string | null>(null);
 
-const deleteThisCamera = (cameraUniqueName: string) => {
+const deleteThisCamera = async (cameraUniqueName: string) => {
   if (deletingCamera.value) return;
   deletingCamera.value = cameraUniqueName;
-  axiosPost("/utils/nukeOneCamera", "delete a camera", { cameraUniqueName: cameraUniqueName }).finally(() => {
+  await axiosPost("/utils/nukeOneCamera", "delete a camera", { cameraUniqueName: cameraUniqueName }).finally(() => {
     deletingCamera.value = null;
   });
 };