Skip to content

Commit 4414b5c

Browse files
xdustinfacePastaPastaPasta
authored andcommitted
llmq: Fix spork check in CSigSharesManager::ForceReAnnouncement (dashpay#3650)
It seems like the idea here was to avoid announcing already available sigshares for a signhash to everyone if concentrated recovery is enabled. But by returning there if `IsAllMembersConnectedEnabled` equals to `false` we disable the re-announcements prior to the spork activation, where we want to still have them and re-enable if the spork is enabled where we don't want to have them.
1 parent c232f2a commit 4414b5c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/llmq/quorums_signing_shares.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1609,7 +1609,7 @@ void CSigSharesManager::Sign(const CQuorumCPtr& quorum, const uint256& id, const
16091609
// causes all known sigShares to be re-announced
16101610
void CSigSharesManager::ForceReAnnouncement(const CQuorumCPtr& quorum, Consensus::LLMQType llmqType, const uint256& id, const uint256& msgHash)
16111611
{
1612-
if (!CLLMQUtils::IsAllMembersConnectedEnabled(llmqType)) {
1612+
if (CLLMQUtils::IsAllMembersConnectedEnabled(llmqType)) {
16131613
return;
16141614
}
16151615

0 commit comments

Comments
 (0)