Skip to content

Makes sure we don't duplicate user ACL's keys #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flovilmart merged 4 commits into from
Sep 9, 2016
Merged

Makes sure we don't duplicate user ACL's keys #2651

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
92f99f8
Adds repro for issue #2246
flovilmart Sep 4, 2016
2efa2f4
Provide fix for issue #2246
flovilmart Sep 4, 2016
f7c5ce8
Nit with Set to deduplicate the acl array
flovilmart Sep 4, 2016
adbb530
remove debuging console.log
flovilmart Sep 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/RestQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ RestQuery.prototype.getUserAndRoleACL = function() {
}
return this.auth.getUserRoles().then((roles) => {
// Concat with the roles to prevent duplications on multiple calls
this.findOptions.acl = this.findOptions.acl.concat(roles);
const aclSet = new Set([].concat(this.findOptions.acl, roles));
this.findOptions.acl = Array.from(aclSet);
return Promise.resolve();
});
};
Expand Down