-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Delete custom op for adamw. #984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -294,33 +294,18 @@ def do_train(args): | |
| p.name for n, p in model.named_parameters() | ||
| if not any(nd in n for nd in ["bias", "norm"]) | ||
| ] | ||
| # TODO @ZHUI Use paddle.optimizer.AdamW | ||
| if ops.optimizer._jit_compile(): | ||
| logger.info("Using paddlenlp custom AdamW optimizer.") | ||
| optimizer = ops.optimizer.AdamwOptimizer( | ||
| learning_rate=lr_scheduler, | ||
| beta1=args.adam_beta1, | ||
| beta2=args.adam_beta2, | ||
| epsilon=args.adam_epsilon, | ||
| grad_clip=clip, | ||
| weight_decay=args.weight_decay, | ||
| apply_decay_param_fun=lambda x: x in decay_param) | ||
| else: | ||
| if args.sharding_degree > 1: | ||
| raise ValueError( | ||
| "The paddle.optimizer.AdamW not compatible with Sharding!" | ||
| ) | ||
| logger.info("Using paddle.optimizer.AdamW.") | ||
| optimizer = paddle.optimizer.AdamW( | ||
| learning_rate=lr_scheduler, | ||
| beta1=args.adam_beta1, | ||
| beta2=args.adam_beta2, | ||
| epsilon=args.adam_epsilon, | ||
| grad_clip=clip, | ||
| weight_decay=args.weight_decay, | ||
| apply_decay_param_fun=lambda x: x in decay_param) | ||
| # alias | ||
| optimizer.apply_optimize = optimizer._apply_optimize | ||
|
|
||
| optimizer = paddle.optimizer.AdamW( | ||
| learning_rate=lr_scheduler, | ||
| beta1=args.adam_beta1, | ||
| beta2=args.adam_beta2, | ||
| epsilon=args.adam_epsilon, | ||
| grad_clip=clip, | ||
| weight_decay=args.weight_decay, | ||
| apply_decay_param_fun=lambda x: x in decay_param) | ||
|
|
||
| # alias | ||
| optimizer.apply_optimize = optimizer._apply_optimize | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 同上
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
|
||
| if args.use_recompute: | ||
| dist_strategy.recompute = True | ||
|
|
@@ -341,12 +326,12 @@ def do_train(args): | |
| if not os.path.isdir(program_desc_dir): | ||
| os.mkdir(program_desc_dir) | ||
|
|
||
| with open(program_desc_dir + "/main_program.txt.%d" % | ||
| (int(os.environ.get('FLAGS_selected_gpus', 0))), 'w') as f: | ||
| with open(program_desc_dir + "/main_program.txt.%d" % worker_index, | ||
| 'w') as f: | ||
| f.write(str(main_program)) | ||
|
|
||
| with open(program_desc_dir + "/startup_program.txt.%d" % | ||
| (int(os.environ.get('FLAGS_selected_gpus', 0))), 'w') as f: | ||
| with open(program_desc_dir + "/startup_program.txt.%d" % worker_index, | ||
| 'w') as f: | ||
| f.write(str(startup_program)) | ||
|
|
||
| # Define the Executor for running the static model | ||
|
|
||
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里是个不兼容的修改,在文档中注明一下使用的paddlepaddle的版本吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done