Skip to content

Conversation

@ZHUI
Copy link
Contributor

@ZHUI ZHUI commented Sep 8, 2021

PR types

Function optimization

PR changes

APIs

Description

Now, Paddle support adamw as op, so we can delete the custom AdamW.
PaddlePaddle/Paddle#35020

weight_decay=args.weight_decay,
apply_decay_param_fun=lambda x: x in decay_param)
# alias
optimizer.apply_optimize = optimizer._apply_optimize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是个不兼容的修改,在文档中注明一下使用的paddlepaddle的版本吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

apply_decay_param_fun=lambda x: x in decay_param)

# alias
optimizer.apply_optimize = optimizer._apply_optimize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ZHUI ZHUI requested a review from wawltor September 8, 2021 07:21
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 7a4f830 into PaddlePaddle:develop Sep 8, 2021
@ZHUI ZHUI deleted the gpt/del_custom_adamw branch September 8, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants