[NPU] Add norm_grad kernel #35237
Merged
[NPU] Add norm_grad kernel #35237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
qili93
reviewed
Aug 31, 2021
| // dx = ( dy/sqrt(sum(x*x)) ) * [1 - x*sum(x) / (sum(x*x) + e)] | ||
| // = [dy - dy * x * sum(x) / (sum(x*x) + e)] / sqrt(sum(x*x)) | ||
| // = [dy - x * sum(x*dy) / (sum(x*x) + e)] / sqrt(sum(x*x)) | ||
|
|
Contributor
There was a problem hiding this comment.
确认下，这个算子在P固定为2的情况下，前向和反向应该都可以和 L2Normalize & L2NormalizeGrad 对齐。
zhangting2020
approved these changes
Sep 7, 2021
Contributor
zhangting2020
left a comment
zhangting2020
left a comment
There was a problem hiding this comment.
LGTM for skip_check_grad_ci
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
* [NPU] fix for test_norm_op_npu * [NPU] add norm_grad * [NPU] add CheckAxis for axis * [NPU] delete debug codes * norm can not use L2Normalize, norm_grad can use L2NormalizeGrad * [NPU] delete useless codes * [NPU] optimize norm_grad OpMaker * Update python import path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add norm_grad kernel