Support gettiem by Bool index #35026
Conversation
|
|
||
| PADDLE_ENFORCE_EQ(index_dim[0] != 0, true, | ||
| platform::errors::InvalidArgument( | ||
| "The length of Input(Index) can't be 0.")); |
There was a problem hiding this comment.
length -> dimension ? 其他维度可以是0吗
There was a problem hiding this comment.
目前IndexSelectOp只支持一维的index索引，所以这里只需判断第0维的长度
| } | ||
| } | ||
| if (all_bool) { | ||
| if (list_size != shape[0]) { |
There was a problem hiding this comment.
why not use PADDLE_ENFORCE_EQ directly
There was a problem hiding this comment.
这里会在setitem支持Bool类型索引的PR中改为使用PADDLE_ENFORCE_EQ
| } | ||
| } | ||
| } else { | ||
| for (int j = 0; j < list_size; ++j) { |
There was a problem hiding this comment.
why this branch no need check?
There was a problem hiding this comment.
当索引中存在整数时，整个index索引list将会以整数类型进行处理，整数list类型的索引没有长度限制，所以没有进行check
| PyObject *list_item = PyList_GetItem(slice_item, j); | ||
| if (PyCheckInteger(list_item)) { | ||
| list_select_idxs->push_back( | ||
| static_cast<int>(PyLong_AsLong(list_item))); |
There was a problem hiding this comment.
当索引中存在整数时，bool类型的True和False分别会被替换为整数类型的1和0进行处理
| dim += rank - specified_dims; | ||
| } else if (slice_item == Py_None) { | ||
| none_axes->push_back(dim); | ||
| } else if (PyList_Check(slice_item)) { |
There was a problem hiding this comment.
是否需要检测tuple的情况，例如：index=（False，True），tensor[index]
There was a problem hiding this comment.
ParseIndexingSlice在开始处理参数前有针对tuple类型的预处理，这里可以不用再做检测
3 participants
PR types
New features
PR changes
APIs
Describe
Support gettiem by Bool index
Example: