Skip to content

Conversation

@Aganlengzi
Copy link
Contributor

@Aganlengzi Aganlengzi commented Aug 9, 2021

PR types

Others

PR changes

OPs

Describe

add NPU op: squared_l2_norm, squared_l2_norm_grad and tests
image
image
image

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Aganlengzi Aganlengzi changed the title [NPU] add squared_l2_norm squared_l2_norm and tests [NPU] add squared_l2_norm squared_l2_norm_grad and tests Aug 9, 2021
{{"axes", axes}, {"keep_dims", false}});
reduce_sum_runner.Run(stream);
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确认下以上2个OP的组合和SquareSumV1是一样的不?如果是的话,建议用SquareSumV1实现。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢,SquareSumV1和Square&ReduceSumD一致,已替换。

Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit b64312f into PaddlePaddle:develop Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants