Skip to content

Added matmul_v2 BF16/FP32 BWD kernel #34192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 30, 2021
Merged

Added matmul_v2 BF16/FP32 BWD kernel #34192

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9e4533d
test version of matmul_v2
jakpiase Jul 13, 2021
11b2b6b
added matmul_v2 grad kernel
jakpiase Jul 15, 2021
9a82a32
merged paddle develop
jakpiase Jul 15, 2021
dfd14d0
minor changes
jakpiase Jul 15, 2021
8caf558
minor changes
jakpiase Jul 15, 2021
ca35af0
minor change for CI approval
jakpiase Jul 15, 2021
1f4b963
CI fix
jakpiase Jul 15, 2021
2104d0d
CI fix
jakpiase Jul 15, 2021
17fe96b
trigger CI
jakpiase Jul 23, 2021
d98678d
changes after review, not working yet
jakpiase Jul 27, 2021
e2e1005
moved ops to anonymous namespaces
jakpiase Jul 28, 2021
7476508
changes after review
jakpiase Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions paddle/fluid/operators/matmul_v2_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,15 @@ class MatMulV2Op : public framework::OperatorWithKernel {
}

std::vector<int64_t> new_dims;
if (ndims_x >= ndims_y) {
if (ndims_x > ndims_y) {
new_dims.assign(dims_x.begin(), dims_x.end() - 2);
} else {
} else if (ndims_x < ndims_y) {
new_dims.assign(dims_y.begin(), dims_y.end() - 2);
} else {
new_dims.reserve(ndims_x);
for (size_t i = 0; i < ndims_x - 2; ++i) {
new_dims.push_back(std::max(dims_x[i], dims_y[i]));
}
}
if (!x_broadcasted) {
new_dims.push_back(M);
Expand Down Expand Up @@ -169,10 +174,17 @@ class MatMulV2OpGrad : public framework::OperatorWithKernel {

framework::OpKernelType GetExpectedKernelType(
const framework::ExecutionContext& ctx) const override {
auto out_grad_name = framework::GradVarName("Out");
return framework::OpKernelType(
OperatorWithKernel::IndicateVarDataType(ctx, out_grad_name),
ctx.GetPlace());
auto input_data_type = OperatorWithKernel::IndicateVarDataType(
ctx, framework::GradVarName("Out"));

#ifdef PADDLE_WITH_MKLDNN
if (this->CanMKLDNNBeUsed(ctx, input_data_type)) {
return framework::OpKernelType(input_data_type, ctx.GetPlace(),
framework::DataLayout::kMKLDNN,
framework::LibraryType::kMKLDNN);
}
#endif
return framework::OpKernelType(input_data_type, ctx.GetPlace());
}

framework::OpKernelType GetKernelTypeForVar(
Expand Down
Loading