Added PRelu BF16/FP32 FWD/BWD kernels #33878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Contributor
Contributor
Author
|
Thank you, I'll delete that. I am glad to know that information |
Contributor
Author
|
Unfortunately disabling check_dygraph that you have mentioned is only in check_output_with_place. The code doesn't work since in check_grad_with_place check_dygraph is not disabled. |
Contributor
Author
|
Since tests will not pass without that line, I will add it back |
Contributor
jczaja
reviewed
Jul 1, 2021
python/paddle/fluid/tests/unittests/mkldnn/test_prelu_mkldnn_op.py
Outdated
Show resolved
Hide resolved
This reverts commit 9dd9a21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Added PRelu BF16/FP32 FWD/BWD kernels
Profiling before this PR:
Profiling after this PR:
So it made ~88% speedup, measured with Intel(R) Core(TM) i9-9940X CPU @ 3.30GHz on mobilefacenet model
It's also a solution for this issue