From ed8d8dce13f5ef17b0b3d9cf5f72a1b178d87471 Mon Sep 17 00:00:00 2001 From: tangwei12 Date: Fri, 12 Jul 2019 11:10:06 +0800 Subject: [PATCH 1/2] delete m, test=develop --- paddle/fluid/memory/allocation/allocator_facade.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/paddle/fluid/memory/allocation/allocator_facade.cc b/paddle/fluid/memory/allocation/allocator_facade.cc index 440b2475f1631c..148d3969726f72 100644 --- a/paddle/fluid/memory/allocation/allocator_facade.cc +++ b/paddle/fluid/memory/allocation/allocator_facade.cc @@ -295,7 +295,7 @@ class AllocatorFacadePrivate { // Pimpl. Make interface clean. AllocatorFacade::AllocatorFacade() : m_(new AllocatorFacadePrivate()) {} -AllocatorFacade::~AllocatorFacade() { delete m_; } +AllocatorFacade::~AllocatorFacade() {} AllocatorFacade& AllocatorFacade::Instance() { static AllocatorFacade instance; From 5239f134176e8555d9defafb48473aa1c7aa9a4a Mon Sep 17 00:00:00 2001 From: tangwei12 Date: Fri, 12 Jul 2019 15:17:32 +0800 Subject: [PATCH 2/2] delete m, test=develop --- paddle/fluid/memory/allocation/allocator_facade.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/paddle/fluid/memory/allocation/allocator_facade.cc b/paddle/fluid/memory/allocation/allocator_facade.cc index 148d3969726f72..7de32094a07b95 100644 --- a/paddle/fluid/memory/allocation/allocator_facade.cc +++ b/paddle/fluid/memory/allocation/allocator_facade.cc @@ -295,6 +295,8 @@ class AllocatorFacadePrivate { // Pimpl. Make interface clean. AllocatorFacade::AllocatorFacade() : m_(new AllocatorFacadePrivate()) {} +// delete m_ may cause core dump when the destructor of python in conflict with +// cpp. AllocatorFacade::~AllocatorFacade() {} AllocatorFacade& AllocatorFacade::Instance() {