polish cmake, test=develop#21681
Merged
Merged
Conversation
zhiqiu
force-pushed
the
dev/refine_cmake
branch
2 times, most recently
from
841cc89 to
b487982
Compare
zhiqiu
force-pushed
the
dev/refine_cmake
branch
from
b487982 to
f1664a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
op_function_generatorpresented in PR21569 needs liboimp5.so(.dll on windows) and libmkldnn.so (.dll on windows) whenWITH_MKLandWITH_MKLDNNis on.This PR carefully copy these dynamic library to the directory where
op_function_generatoris, and add that directory toLD_LIBRARY_PATH, soop_function_generatorcan run.This also fixes #21692.