add CI check for white list, test=develop

Author: zhiqiu

paddle/fluid/framework/unused_var_check.cc

@@ -64,7 +64,7 @@ void CheckUnusedVar(const OperatorBase &op) {
       err_msg += ", ";
     }
     err_msg += "please remove it from inputs or register NoNeedBufferVars!";
-    LOG(ERROR) << err_msg;
+    VLOG(1) << err_msg;
   }
 }
 

paddle/scripts/paddle_build.sh

@@ -436,8 +436,11 @@ EOF
         fi
 
         # TODO: jiabin need to refine this part when these tests fixed on mac
-        ctest --output-on-failure -j $2
-
+        # ctest --output-on-failure -j $2
+        # NOTE(cql): output logs of LOG(ERROR) to check unused vars.
+        export FLAGS_enable_unused_var_check=1
+        export GLOG_vmodule=unused_var_check=2
+        ctest -VV -j $2 -O log.txt
         paddle version
     fi
 }

tools/check_api_approvals.sh

@@ -25,7 +25,8 @@ API_FILES=("CMakeLists.txt"
            "python/paddle/fluid/parallel_executor.py"
            "python/paddle/fluid/framework.py"
            "python/paddle/fluid/backward.py"
-           "paddle/fluid/operators/distributed/send_recv.proto.in")
+           "paddle/fluid/operators/distributed/send_recv.proto.in"
+           "tools/generate_op_use_unused_inputs_white_list.py")
 
 approval_line=`curl -H "Authorization: token ${GITHUB_API_TOKEN}" https://api.github.com/repos/PaddlePaddle/Paddle/pulls/${GIT_PR_ID}/reviews?per_page=10000`
 git_files=`git diff --numstat upstream/$BRANCH| wc -l`
@@ -67,7 +68,7 @@ for API_FILE in ${API_FILES[*]}; do
   echo "checking ${API_FILE} change, PR: ${GIT_PR_ID}, changes: ${API_CHANGE}"
   if [ "${API_CHANGE}" ] && [ "${GIT_PR_ID}" != "" ]; then
       # NOTE: per_page=10000 should be ok for all cases, a PR review > 10000 is not human readable.
-      # approval_user_list: XiaoguangHu01 46782768,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,qingqing01 7845005,guoshengCS 14105589,heavengate 12605721,kuke 3064195,Superjomn 328693,lanxianghit 47554610,cyj1986 39645414,hutuxian 11195205,frankwhzhang 20274488,nepeplwu 45024560,Dianhai 38231817,JiabinYang 22361972,chenwhql 22561442,seiriosPlus 5442383,gongweibao 10721757,saxon-zh 2870059,Boyan-Liu 2870059. 
+      # approval_user_list: XiaoguangHu01 46782768,Xreki 12538138,luotao1 6836917,sneaxiy 32832641,qingqing01 7845005,guoshengCS 14105589,heavengate 12605721,kuke 3064195,Superjomn 328693,lanxianghit 47554610,cyj1986 39645414,hutuxian 11195205,frankwhzhang 20274488,nepeplwu 45024560,Dianhai 38231817,JiabinYang 22361972,chenwhql 22561442,zhiqiu 6888866,seiriosPlus 5442383,gongweibao 10721757,saxon-zh 2870059,Boyan-Liu 2870059. 
       if [ "${API_FILE}" == "paddle/fluid/op_use_default_grad_op_maker.spec" ];then
         APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 32832641 6836917`
       elif [ "${API_FILE}" == "CMakeLists.txt" ];then
@@ -78,6 +79,8 @@ for API_FILE in ${API_FILES[*]}; do
          APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 6836917 22361972`
       elif [ "${API_FILE}" == "paddle/fluid/operators/distributed/send_recv.proto.in" ];then
          APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 10721757 5442383`
+      elif [ "${API_FILE}" == "tools/generate_op_use_unused_inputs_white_list.py" ];then
+        APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 6888866 32832641 6836917`
       else
         APPROVALS=`echo ${approval_line}|python ${PADDLE_ROOT}/tools/check_pr_approval.py 1 3048612 46782768 12538138 6836917 32832641`
       fi
@@ -103,6 +106,10 @@ for API_FILE in ${API_FILES[*]}; do
           failed_num=`expr $failed_num + 1`
           echo_line="You must have one RD (gongweibao or seiriosPlus) approval for the paddle/fluid/operators/distributed/send_recv.proto.in, which manages the environment variables.\n"
           echo_list=(${echo_list[@]}$failed_num "." $echo_line)
+        elif [ "${API_FILE}" == "tools/generate_op_use_unused_inputs_white_list.py" ];then
+          failed_num=`expr $failed_num + 1`
+          echo_line="You must have one RD (zhiqiu (Recommend) , sneaxiy or luotao1) approval for the tools/generate_op_use_unused_inputs_white_list.py, which manages the white list of oerators that have unused input variables.\n"
+          echo_list=(${echo_list[@]}$failed_num "." $echo_line)
         else
           failed_num=`expr $failed_num + 1`
           echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1,sneaxiy) approval for ${API_FILE}, which manages the underlying code for fluid.\n"