Skip to content

Commit 71d1c1e

Browse files
committed
Add zhhsplendid into PE approver, test=develop
1 parent 3eb106d commit 71d1c1e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tools/check_file_diff_approvals.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ API_FILES=("CMakeLists.txt"
3333
"paddle/fluid/framework/ir/node.h"
3434
"paddle/fluid/framework/ir/graph.h"
3535
"paddle/fluid/framework/framework.proto"
36-
"python/paddle/distributed/__init"
37-
"python/paddle/distributed/fleet/__init__.py"
36+
"python/paddle/distributed/__init"
37+
"python/paddle/distributed/fleet/__init__.py"
3838
"python/requirements.txt"
3939
"python/paddle/fluid/__init__.py"
4040
"python/paddle/fluid/compiler.py"
@@ -143,9 +143,12 @@ for API_FILE in ${API_FILES[*]}; do
143143
elif [ "${API_FILE}" == "paddle/scripts/paddle_build.bat" ]; then
144144
echo_line="You must have one RD (zhouwei25 (Recommend), luotao1) approval for ${API_FILE} changes, which manages all Paddle CI task on Windows.\n"
145145
check_approval 1 52485244 6836917
146+
elif [ "${API_FILE}" == "python/paddle/fluid/parallel_executor.py" ]; then
147+
echo_line="You must have one RD (Xreki,luotao1,zhhsplendid) approval for ${API_FILE}, which manages the underlying code for PaddlePaddle.\n"
148+
check_approval 1 12538138 6836917 7913861
146149
else
147150
echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for ${API_FILE}, which manages the underlying code for fluid.\n"
148-
check_approval 1 3048612 46782768 12538138 6836917
151+
check_approval 1 46782768 12538138 6836917
149152
fi
150153
fi
151154
done
@@ -154,7 +157,7 @@ FILTER=`git diff --name-only upstream/develop | grep -v "tools/"`
154157
HAS_CONST_CAST=`git diff -U0 upstream/$BRANCH $FILTER |grep -o -m 1 "const_cast" || true`
155158
if [ ${HAS_CONST_CAST} ] && [ "${GIT_PR_ID}" != "" ]; then
156159
echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for the usage (either add or delete) of const_cast.\n"
157-
check_approval 1 3048612 46782768 12538138 6836917
160+
check_approval 1 46782768 12538138 6836917
158161
fi
159162

160163
HAS_BOOST_GET=`git diff -U0 upstream/$BRANCH $FILTER |grep "^+" |grep -o -m 1 "boost::get" || true`

0 commit comments

Comments
 (0)