fix review

Author: 0x45f

python/paddle/fluid/dygraph/dygraph_to_static/error.py

@@ -143,6 +143,23 @@ def formated_message(self):
         return msg + '\n'.join(self.source_code) + '\n'
 
 
+class SuggestionDict(object):
+    def __init__(self):
+        # {(keywords): (suggestions)}
+        self.suggestion_dict = {
+            ('is not initialized.', 'Hint:', 'IsInitialized'):
+            ("Please ensure all your sublayers are inheritted from nn.Layer.",
+             "Please ensure there is no tensor created explicitly depended on external data, we suggest to register it as buffer tensor. See https://www.paddlepaddle.org.cn/documentation/docs/zh/guides/04_dygraph_to_static/export_model/principle_cn.html#parameters-buffers for details"
+             )
+        }
+
+    def keys(self):
+        return self.suggestion_dict.keys()
+
+    def __getitem__(self, key):
+        return self.suggestion_dict[key]
+
+
 class ErrorData(object):
     """
     Error data attached to an exception which is raised in un-transformed code.
@@ -155,6 +172,7 @@ def __init__(self, error_type, error_value, origin_traceback,
         self.origin_traceback = origin_traceback
         self.origin_info_map = origin_info_map
         self.in_runtime = False
+        self.suggestion_dict = SuggestionDict()
 
     def create_exception(self):
         message = self.create_message()
@@ -216,27 +234,20 @@ def create_message(self):
         return '\n'.join(message_lines)
 
     def _create_revise_suggestion(self, bottom_error_message):
-        # {(keywords): [suggestions]}
-        suggestion_dict = {
-            ('is not initialized.', 'Hint:', 'IsInitialized'): [
-                "Ensure all sublayers inherit nn.Layer.",
-                "Ensure layer's inputs should be buffer Variables. For more information, please refer to: https://www.paddlepaddle.org.cn/documentation/docs/zh/guides/04_dygraph_to_static/export_model/principle_cn.html#parameters-buffers"
-            ]
-        }
         revise_suggestions = [
-            ' ' * BLANK_COUNT_BEFORE_FILE_STR + 'Revise suggestion: '
+            '', ' ' * BLANK_COUNT_BEFORE_FILE_STR + 'Revise suggestion: '
         ]
-        for keywords in suggestion_dict.keys():
+        for keywords in self.suggestion_dict.keys():
             contain_keywords = [
                 True for i in keywords if i in ''.join(bottom_error_message)
             ]
             if len(contain_keywords) == len(
                     keywords):  # all keywords should be in bottom_error_message
-                for suggestion in suggestion_dict[keywords]:
+                for suggestion in self.suggestion_dict[keywords]:
                     suggestion_msg = ' ' * BLANK_COUNT_BEFORE_FILE_STR * 2 + '{}. {}'.format(
-                        str(len(revise_suggestions)), suggestion)
+                        str(len(revise_suggestions) - 1), suggestion)
                     revise_suggestions.append(suggestion_msg)
-        return revise_suggestions if len(revise_suggestions) > 1 else []
+        return revise_suggestions if len(revise_suggestions) > 2 else []
 
     def _simplify_error_value(self):
         """

python/paddle/fluid/dygraph/dygraph_to_static/partial_program.py

@@ -476,9 +476,10 @@ def _check_params_all_inited(self, main_program):
                         raise ValueError(
                             "\n\tWe don't support to define layer with parameters in the function decorated by `@to_static`."
                             "\n\tBut we found parameter(%s) was created in the decorated function."
+                            "\n"
                             "\n\tRevise suggestion: "
-                            "\n\t\t1. Ensure all sublayers inherit nn.Layer"
-                            "\n\t\t2. Should use nn.ParameterList and nn.LayerList as container instead of using a native Python container such as List"
+                            "\n\t\t1. Please ensure all your sublayers are inheritted from nn.Layer."
+                            "\n\t\t2. Please use nn.ParameterList and nn.LayerList as container instead of using a native Python container such as List"
                             % name)
 
     def _valid_vars(self, vars):

python/paddle/fluid/tests/unittests/dygraph_to_static/test_error.py

@@ -431,8 +431,8 @@ def set_message(self):
                 '<--- HERE',
                 'return out',
                 'Revise suggestion:',
-                'Ensure all sublayers inherit nn.Layer.',
-                'Ensure layer\'s inputs should be buffer Variables. For more information, please refer to:'
+                'Please ensure all your sublayers are inheritted from nn.Layer.',
+                'Please ensure there is no tensor created explicitly depended on external data, we suggest to register it as buffer tensor. See'
             ]
 
     def set_func_call(self):