Skip to content

remove default task #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

remove default task #329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
652e762
remove default task
alytarik Apr 13, 2023
bd72b66
check if the task is valid
alytarik Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions nlptest/nlptest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class Harness:
Harness class evaluates the performance of a given NLP model. Given test data is
used to test the model. A report is generated with test results.
"""
SUPPORTED_TASKS = ["ner", "text-classification"]
SUPPORTED_HUBS = ["spacy", "huggingface", "johnsnowlabs"]
DEFAULTS_DATASET = {
("ner", "dslim/bert-base-NER", "huggingface"): "conll/sample.conll",
Expand All @@ -36,7 +37,7 @@ class Harness:
def __init__(
self,
model: Union[str, Any],
task: Optional[str] = "ner",
task: str,
hub: Optional[str] = None,
data: Optional[str] = None,
config: Optional[Union[str, dict]] = None
Expand All @@ -56,6 +57,9 @@ def __init__(
"""

super().__init__()

if(task not in self.SUPPORTED_TASKS):
raise ValueError(f"Provided task is not supported. Please choose one of the supported tasks: {self.SUPPORTED_TASKS}")
self.task = task

if isinstance(model, str) and hub is None:
Expand Down Expand Up @@ -310,7 +314,7 @@ def save(self, save_dir: str) -> None:
pickle.dump(self.data, writer)

@classmethod
def load(cls, save_dir: str, model: Union[str, 'ModelFactory'], task: Optional[str] = "ner",
def load(cls, save_dir: str, model: Union[str, 'ModelFactory'], task: str,
hub: Optional[str] = None) -> 'Harness':
"""
Loads a previously saved `Harness` from a given configuration and dataset
Expand Down