Nuxt icons#824
Conversation
|
Any news about this? Do you need something modified or fixed on these new icons? Let me know :) |
|
I apologize that you had to wait so long. The icons look very good. I still need a final review in the editor to check how it looks and feels and then it's very likely that it will be merged. Give me a few more days, I put it on top of my todo list for this extension :) |
|
No problem at all, thanks :) |
…n-theme into pr/stefanobartoletti/824
PKief
left a comment
There was a problem hiding this comment.
I just reviewed the icons and there was still something to do here.
Here you can see the new icons which were originally part of your PR:

The issue that I saw here was that some of the contrast got lost which was more present with the old icons:

This is why I decided to create two separate versions, one for dark and another one for light themes:

On the folder icon, the triangles all have the same white color, because first, this fits better to all other folder icons in this extension and second, it provides a little better contrast.
I already pushed the changes and I hope the changes are fine for you.
|
They look great, and are following the same standards as in the official Nuxt branding guidelines :) |
|
Thank you for the feedback :) I will update the extension on the VS Code Marketplace soon. |

Updated Nuxt icons to reflect the new branding of the project; more details here https://nuxtjs.org/design