Skip to content

harmonise/clarify wording of Toggle Explorer Arrows#1749

Merged
PKief merged 3 commits into
material-extensions:mainfrom
hughlilly:explorer-arrows-wording
Nov 3, 2022
Merged

harmonise/clarify wording of Toggle Explorer Arrows#1749
PKief merged 3 commits into
material-extensions:mainfrom
hughlilly:explorer-arrows-wording

Conversation

@hughlilly

@hughlilly hughlilly commented Nov 1, 2022

Copy link
Copy Markdown
Contributor

This PR sets the wording of Toggle Explorer Arrows to be more explicit. It also makes minor clarifying changes to wording of some descriptions in the Commands section of README.md.

Successfully merging it would require re-doing the Commands screenshot at
https://github.com/PKief/vscode-material-icon-theme/blob/5e57ec33d3402f325b3e711a6eb34bc3b90c2b1c/README.md?plain=1#L169

also makes minor clarifying changes to wording of some descriptions in the Commands section of README.md

@PKief PKief left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, I like your changes. They are pretty valuable and improve the description of the extension.

Comment thread README.md Outdated
Comment thread src/i18n/lang-en.ts Outdated
@hughlilly

Copy link
Copy Markdown
Contributor Author

I think I’ve resolved the two issues. As previously mentioned merging this would require an updated screenshot. I’ll leave that to you. Thanks!

@PKief PKief merged commit 51e2472 into material-extensions:main Nov 3, 2022
Anselmoo pushed a commit to Anselmoo/vscode-material-icon-theme that referenced this pull request Nov 5, 2022
…ons#1749)

* harmonise/clarify wording of Toggle Explorer Arrows

also makes minor clarifying changes to wording of some descriptions in the Commands section of README.md

* format with prettier

* use en-US
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants