feat: svgr#1218
Merged
Merged
Conversation
PKief
reviewed
Aug 25, 2021
Member
PKief
left a comment
PKief
left a comment
There was a problem hiding this comment.
Thanks for the contribution but I think the icon is not suitable to be used within this extension. The inner icon of the fox (?) is way to small to be recognized in the file explorer of VS Code and will not look pretty good.
I think we should definitely abstract this icon a little bit. Either we use the original react icon with another color (e.g. orange) or a simplified version of the animal inside.
Member
|
@bart-krakowski What do you think about this suggestion?
It's basically the react icon with |
PKief
reviewed
Sep 5, 2021
PKief
approved these changes
Sep 5, 2021
Member
PKief
left a comment
PKief
left a comment
There was a problem hiding this comment.
Looks good to me now :) Thanks for your work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added an icon for the SVGR config file according to this document.