added icon for context#1106
Merged
Merged
Conversation
PKief
approved these changes
Jul 12, 2021
Member
PKief
left a comment
PKief
left a comment
There was a problem hiding this comment.
Hey, sorry for the late reply. I just looked at your PR for a context folder icon and I like the idea very much. I had to adjust the folder color a little bit so that the contrast in File Explorer is even better and you can see the icon well. Thank you very much for your contribution. The icon will be part of the next update :)
Contributor
Author
|
Thank you very very much for the consideration! It feels really nice to have my contribution accepted =) |
This was referenced Jul 14, 2021
THANK YOU |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello friend!
This is my first time ever doing a pull request. Feel free to give any tips on thing i can do better next time!
This PR was motivated by a common practice i have while programming react applications, that is creating a
contextsfolder. So i thought i would be nice to have a folder icon for that =)The process i followed was based on the .md file for contributions. I downloaded the .svg icons for folder, folder-open and sitemap from material icons. Then i edited on GIMP, saved as png, and exported to .svg via the recommended links on the contributing .md.
Thank you in advance for considering this PR! =)