Skip to content

Commit 59629af

Browse files
committed
feat: add CHANGELOG hyperlink in demo app (Orange-OpenSource/ouds-ios#678)
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
1 parent 460673a commit 59629af

File tree

3 files changed

+59
-0
lines changed

3 files changed

+59
-0
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/compare/0.15.0...develop)
88

9+
### Added
10+
11+
- [DesignToolbox] Add in about page link to online CHANGELOG (Orange-OpenSource/ouds-ios#678)
12+
913
### Changed
1014

1115
- [Tool] Update `SwiftFormat/CLI` pod from v0.56.1 to v0.56.2

DesignToolbox/DesignToolbox/Pages/About/AboutPage.swift

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ struct AboutPage: View {
2424
private let appSourcesUrl: URL
2525
private let bugReportUrl: URL
2626
private let designSystemUrl: URL
27+
private let changelogURL: URL
2728

2829
@Environment(\.layoutDirection) private var layoutDirection
2930

@@ -54,12 +55,17 @@ struct AboutPage: View {
5455
OL.fatal("Unable to forge design system URL")
5556
}
5657

58+
guard let changelogURL = URL(string: "https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/CHANGELOG.md") else {
59+
OL.fatal("Unable to forge changelog URL")
60+
}
61+
5762
privacyPolicyUrl = privacyNoticeUrl
5863
self.legalInformationUrl = legalInformationUrl
5964
self.appSettingsUrl = appSettingsUrl
6065
self.appSourcesUrl = appSourcesUrl
6166
self.bugReportUrl = bugReportUrl
6267
self.designSystemUrl = designSystemUrl
68+
self.changelogURL = changelogURL
6369
}
6470

6571
// MARK: Body
@@ -132,6 +138,7 @@ struct AboutPage: View {
132138
}
133139
}.accessibilityHint("app_about_appSettings_hint_a11y")
134140

141+
link(changelogURL, label: "app_about_changelog_label", hint: "app_about_changelog_hint_a11y")
135142
link(appSourcesUrl, label: "app_about_appSources_label", hint: "app_about_appSources_hint_a11y")
136143
link(bugReportUrl, label: "app_about_bugReport_label", hint: "app_about_bugReport_hint_a11y")
137144
link(designSystemUrl, label: "app_about_designSystem_label", hint: "app_about_designSystem_hint_a11y")

DesignToolbox/DesignToolbox/Resources/Localizable.xcstrings

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,54 @@
191191
}
192192
}
193193
},
194+
"app_about_changelog_hint_a11y" : {
195+
"comment" : "About screen - Changelog hint",
196+
"extractionState" : "manual",
197+
"localizations" : {
198+
"ar" : {
199+
"stringUnit" : {
200+
"state" : "translated",
201+
"value" : "انقر مرتين للانتقال إلى سجل التغيير عبر الإنترنت للمشروع"
202+
}
203+
},
204+
"en" : {
205+
"stringUnit" : {
206+
"state" : "translated",
207+
"value" : "Tap twice to go the the changelog of the project"
208+
}
209+
},
210+
"fr" : {
211+
"stringUnit" : {
212+
"state" : "translated",
213+
"value" : "Tappez deux fois pour accéder en ligne aux notes de versions"
214+
}
215+
}
216+
}
217+
},
218+
"app_about_changelog_label" : {
219+
"comment" : "About screen - Changelog URL",
220+
"extractionState" : "manual",
221+
"localizations" : {
222+
"ar" : {
223+
"stringUnit" : {
224+
"state" : "translated",
225+
"value" : "انظر ملاحظات الإصدار"
226+
}
227+
},
228+
"en" : {
229+
"stringUnit" : {
230+
"state" : "translated",
231+
"value" : "See changelog"
232+
}
233+
},
234+
"fr" : {
235+
"stringUnit" : {
236+
"state" : "translated",
237+
"value" : "Voir les notes de version"
238+
}
239+
}
240+
}
241+
},
194242
"app_about_designSystem_hint_a11y" : {
195243
"comment" : "About screen - Design system (a11y)",
196244
"extractionState" : "manual",

0 commit comments

Comments
 (0)