ci: remove periphery GitHub Actions workflow

Periphery is a nice tool but has some issues with numerous false positive cases.
It needs also to compile projects for all targets.
In GitHub Actions it failed sometimes to build for other OS than iOS and iPadOS.
In addition it consumes time and budget, and because of false positive cases errors
are accepted and lost in noise with warnings.
This Periphery must be used locally to have a manuel check of the results while false
positive cases remain.

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>

Author: pylapp

.github/DEVELOP.md

@@ -603,16 +603,20 @@ To apply use, run in your project (e.g. once cloned):
 git config --local --add core.hooksPath .git-hooks
 ```
 
+*SwiftFormat* is not used in GitHub Actions CI/CD because sources should be formatted before beeing pushed, not after.
+
 ## Dead code
 
 We use [Periphery](https://github.com/peripheryapp/periphery) to look for dead code and help developers to track it and remove it.
-This tool is run in CI/CD side and can be run localy using *Fastlane*:
+This tool should be run locally, for example using *Fastlane*:
 
 And run:
 ```shell
 bundle exec fastlane check_dead_code
 ```
 
+Because _Periphery_ has several issues about false positive, and needs to compile the project to look for symbols, this tool is not used anymore in CI/CD on GitHub Actions. Indeed we needed to allow errors and treat errors as warnings, so as manual check was still needed.
+
 You can also in Xcode run from the *Periphery* scheme so as to make a scan.
 
 > [!CAUTION]
@@ -676,12 +680,12 @@ We use *GitHub Actions* so as to define a workflow with some actions to build de
 It will help us to ensure code on pull requests or being merged compiles and has all tests green.
 
 Workflows are the following:
-- [build-and-test](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/workflows/build-and-test.yml) to build and run unit tests
-- [gitleaks](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/workflows/gitleaks.yml) to check if there are secrets leaks
-- [periphery](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/workflows/periphery.yml) to check if there is dead code
-- [scorecard](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/workflows/scorecard.yml) to buold the OpenSSF score card on README
-- [swiftlint](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/workflows/swiftlint.yml) to check if there is no linter warnings
-- [swiftpolyglot](https://github.com/Orange-OpenSource/ouds-ios/blob/develop/.github/workflows/swiftpolyglot.yml) to check if there are localizations troubles
+- [build-and-test](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/.github/workflows/build-and-test.yml) to build and run unit tests
+- [dependency-review](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/.github/workflows/dependency-review.yml) to scan dependency manifest files surfacing known-vulnerable versions of the packages declared or updated in pull requests
+- [gitleaks](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/.github/workflows/gitleaks.yml) to check if there are secrets leaks
+- [scorecard](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/.github/workflows/scorecard.yml) to build the OpenSSF score card on README
+- [swiftlint](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/.github/workflows/swiftlint.yml) to check if there is no linter warnings
+- [swiftpolyglot](https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/blob/develop/.github/workflows/swiftpolyglot.yml) to check if there are localizations troubles
 
 We use also two GitHub apps making controls on pull requests and defining wether or not prerequisites are filled or not.
 There is one control to check if [PR template are all defined ](https://github.com/stilliard/github-task-list-completed), and one if [DCO is applied](https://probot.github.io/apps/dco/).

.github/workflows/periphery.yml

@@ -19,8 +19,6 @@
  
 <a href="https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/actions/workflows/swiftpolyglot.yml" title="SwiftPolyglot status"><img src="https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/actions/workflows/swiftpolyglot.yml/badge.svg" alt="SwiftPolyglot status"></a>
 &nbsp;
-<a href="https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/actions/workflows/periphery.yml" title="Periphery status"><img src="https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/actions/workflows/periphery.yml/badge.svg" alt="Periphery status"></a>
-&nbsp;
 <a href="https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/actions/workflows/swiftlint.yml" title="SwiftLint status"><img src="https://github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/actions/workflows/swiftlint.yml/badge.svg" alt="SwiftLint status"></a>
 &nbsp;
 <a href="https://scorecard.dev/viewer/?uri=github.com/Orange-OpenSource/ouds-ios-design-system-toolbox" title="OpenSSF Scorecard"><img src="https://api.scorecard.dev/projects/github.com/Orange-OpenSource/ouds-ios-design-system-toolbox/badge" alt="OpenSSF Scorecard"></a>  

README.md

@@ -111,7 +111,7 @@ You may download the source code on the [following website](https://github.com/g
 You may download the source code on the [following website](https://github.com/anchore/grype).
 
 #### Periphery
-<!-- Xcode target -->
+<!-- (CI/CD, tools, etc.) -->
 
 Copyright (c) 2019 Ian Leitch