Skip to content

[OUDS] fix(docs): resolve font icon by building assets in branded folder#3195

Merged
vprothais merged 2 commits into
ouds/mainfrom
ouds/main-ml-icon-font-not-resolving-since-sosh-integration
Nov 4, 2025
Merged

[OUDS] fix(docs): resolve font icon by building assets in branded folder#3195
vprothais merged 2 commits into
ouds/mainfrom
ouds/main-ml-icon-font-not-resolving-since-sosh-integration

Conversation

@MaxLardenois

@MaxLardenois MaxLardenois commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Closes #3194

Context & Motivation

Icons from fonts not displayed

Description

  • Change astro assets build target to branded folder.
  • Move font CSS import from docs_prod.scss and docs.scss to Astro components Scss and ScssProd to be able to customize it according to the brand

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify

netlify Bot commented Oct 21, 2025

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d6dd97a
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6909f49e77f00200086fc72c
😎 Deploy Preview https://deploy-preview-3195--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MaxLardenois

MaxLardenois commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator Author

There could be an argument on moving all the font face declarations in a single file (with a solaris-icons-[brand] name) and just having a branded css for the .si::before { font-family: solaris-icons-sosh }
I don't know what you think about that.

For example:
@import '../../../static/[brand]/docs/[version]/assets/css/font-icons';
in Scss.astro and ScssProd.astro

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 4, 2025
@vprothais vprothais merged commit c527a4e into ouds/main Nov 4, 2025
11 checks passed
@vprothais vprothais deleted the ouds/main-ml-icon-font-not-resolving-since-sosh-integration branch November 4, 2025 12:54
@github-project-automation github-project-automation Bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Nov 4, 2025
@vprothais

Copy link
Copy Markdown
Collaborator

There could be an argument on moving all the font face declarations in a single file (with a solaris-icons-[brand] name) and just having a branded css for the .si::before { font-family: solaris-icons-sosh } I don't know what you think about that.

For example: @import '../../../static/[brand]/docs/[version]/assets/css/font-icons'; in Scss.astro and ScssProd.astro

Interesting point, I think what you did here is simple enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants