You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There could be an argument on moving all the font face declarations in a single file (with a solaris-icons-[brand] name) and just having a branded css for the .si::before { font-family: solaris-icons-sosh }
I don't know what you think about that.
For example: @import '../../../static/[brand]/docs/[version]/assets/css/font-icons';
in Scss.astro and ScssProd.astro
There could be an argument on moving all the font face declarations in a single file (with a solaris-icons-[brand] name) and just having a branded css for the .si::before { font-family: solaris-icons-sosh } I don't know what you think about that.
For example: @import '../../../static/[brand]/docs/[version]/assets/css/font-icons'; in Scss.astro and ScssProd.astro
Interesting point, I think what you did here is simple enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change
Related issues
Closes #3194
Context & Motivation
Icons from fonts not displayed
Description
docs_prod.scssanddocs.scssto Astro components Scss and ScssProd to be able to customize it according to the brandChecklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews