Skip to content

[OUDS] fix(component): prevent tags decorative icon from growing with font size#3179

Merged
vprothais merged 5 commits into
ouds/mainfrom
ouds/main-ml-tags-decorative-icon-fix
Oct 17, 2025
Merged

[OUDS] fix(component): prevent tags decorative icon from growing with font size#3179
vprothais merged 5 commits into
ouds/mainfrom
ouds/main-ml-tags-decorative-icon-fix

Conversation

@MaxLardenois

@MaxLardenois MaxLardenois commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Partially closes #3160

Context & Motivation

See https://teams.microsoft.com/l/message/19:154630ca69564f30b8c8fb3380b065a3@thread.tacv2/1759481948216?tenantId=90c7a20a-f34b-40bf-bc48-b9253b6f5d20&groupId=6cbb6683-5051-4161-9198-6c1a951c7430&parentMessageId=1759481948216&teamName=OUDS%20Core%20Team&channelName=OUDS%20%F0%9F%A6%BB%20Accessibility&createdTime=1759481948216

Description

Differentiates decorative icons sizes from informative ones

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@MaxLardenois MaxLardenois changed the title Ouds/main ml tags decorative icon fix [OUDS] fix(component): prevent tags decorative icon from growing with font size Oct 15, 2025
@netlify

netlify Bot commented Oct 15, 2025

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 2d26201
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/68efa4934f37060008c8591f
😎 Deploy Preview https://deploy-preview-3179--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 15, 2025

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d7786f0
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/68f2086b72f75d00089c05fb
😎 Deploy Preview https://deploy-preview-3179--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hannahiss hannahiss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Oct 15, 2025
@vprothais vprothais merged commit c76b2a0 into ouds/main Oct 17, 2025
11 checks passed
@vprothais vprothais deleted the ouds/main-ml-tags-decorative-icon-fix branch October 17, 2025 12:43
@github-project-automation github-project-automation Bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[OUDS] Decorative icons should not grow with font size

4 participants