Skip to content

Form helper: fix overlapping with required star and form helper#2958

Merged
vprothais merged 2 commits into
mainfrom
main-lmp-fix-form-helper
Apr 14, 2025
Merged

Form helper: fix overlapping with required star and form helper#2958
vprothais merged 2 commits into
mainfrom
main-lmp-fix-form-helper

Conversation

@louismaximepiton

@louismaximepiton louismaximepiton commented Apr 9, 2025

Copy link
Copy Markdown
Member

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2871.

Description

Add a margin-left to .form-helper when following a required label.

Motivation & Context

NA

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify

netlify Bot commented Apr 9, 2025

Copy link
Copy Markdown

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d162a46
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/67fcbdf18c40d8000842d972
😎 Deploy Preview https://deploy-preview-2958--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 14, 2025
@vprothais vprothais merged commit 409c740 into main Apr 14, 2025
@vprothais vprothais deleted the main-lmp-fix-form-helper branch April 14, 2025 07:52
@github-project-automation github-project-automation Bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Required star hidden by Form helper

3 participants