Skip to content

Commit ac713f0

Browse files
committed
Improve tests
1 parent f2ce027 commit ac713f0

File tree

1 file changed

+33
-18
lines changed

1 file changed

+33
-18
lines changed

test/utils/Strings.test.js

Lines changed: 33 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -108,27 +108,42 @@ describe('Strings', function () {
108108
});
109109
});
110110

111-
describe('toHexString address', function () {
112-
it('converts a random address', async function () {
113-
const addr = '0xa9036907dccae6a1e0033479b12e837e5cf5a02f';
114-
expect(await this.mock.getFunction('$toHexString(address)')(addr)).to.equal(addr);
115-
});
116-
117-
it('converts an address with leading zeros', async function () {
118-
const addr = '0x0000e0ca771e21bd00057f54a68c30d400000000';
119-
expect(await this.mock.getFunction('$toHexString(address)')(addr)).to.equal(addr);
120-
});
121-
});
111+
describe('addresses', function () {
112+
const addresses = [
113+
'0xa9036907dccae6a1e0033479b12e837e5cf5a02f', // Random address
114+
'0x0000e0ca771e21bd00057f54a68c30d400000000', // Leading and trailing zeros
115+
// EIP-55 reference
116+
'0x5aAeb6053F3E94C9b9A09f33669435E7Ef1BeAed',
117+
'0xfB6916095ca1df60bB79Ce92cE3Ea74c37c5d359',
118+
'0xdbF03B407c01E7cD3CBea99509d93f8DDDC8C6FB',
119+
'0xD1220A0cf47c7B9Be7A2E6BA89F429762e7b9aDb',
120+
'0xfb6916095ca1df60bb79ce92ce3ea74c37c5d359',
121+
'0x52908400098527886E0F7030069857D2E4169EE7',
122+
'0x8617E340B3D01FA5F11F306F4090FD50E238070D',
123+
'0xde709f2102306220921060314715629080e2fb77',
124+
'0x27b1fdb04752bbc536007a920d24acb045561c26',
125+
'0x5aaeb6053f3e94c9b9a09f33669435e7ef1beaed',
126+
'0xfB6916095ca1df60bB79Ce92cE3Ea74c37c5d359',
127+
'0xdbF03B407c01E7cD3CBea99509d93f8DDDC8C6FB',
128+
'0xD1220A0cf47c7B9Be7A2E6BA89F429762e7b9aDb',
129+
];
122130

123-
describe('toChecksumHexString address', function () {
124-
it('converts a random address', async function () {
125-
const addr = '0xa9036907dccae6a1e0033479b12e837e5cf5a02f';
126-
expect(await this.mock.getFunction('$toChecksumHexString(address)')(addr)).to.equal(ethers.getAddress(addr));
131+
describe('toHexString', function () {
132+
for (const addr of addresses) {
133+
it(`converts ${addr}`, async function () {
134+
expect(await this.mock.getFunction('$toHexString(address)')(addr)).to.equal(addr.toLowerCase());
135+
});
136+
}
127137
});
128138

129-
it('converts an address with leading zeros', async function () {
130-
const addr = '0x0000e0ca771e21bd00057f54a68c30d400000000';
131-
expect(await this.mock.getFunction('$toChecksumHexString(address)')(addr)).to.equal(ethers.getAddress(addr));
139+
describe('toChecksumHexString', function () {
140+
for (const addr of addresses) {
141+
it(`converts ${addr}`, async function () {
142+
expect(await this.mock.getFunction('$toChecksumHexString(address)')(addr)).to.equal(
143+
ethers.getAddress(addr.toLowerCase()),
144+
);
145+
});
146+
}
132147
});
133148
});
134149

0 commit comments

Comments
 (0)