Fix osi trace robustness #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmai
added
the
Bug
pmai
added
the
ReadyForCCBReview
ClemensLinnhoff
approved these changes
Apr 6, 2024
thomassedlmayer
approved these changes
Apr 8, 2024
Contributor
Author
|
CCB 2024-05-06: Merge as-is. |
pmai
added
ReadyToMerge
Signed-off-by: Pierre R. Mai <[email protected]>
As noted by @ClemensLinnhoff there is a precedence error in retrieve_offsets of osi3trace which results in errors if the function is called again after a complete read. Signed-off-by: Pierre R. Mai <[email protected]>
pmai
force-pushed
the
fix/osi-trace-robustness
branch
from
123bbb2 to
ee47d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by @ClemensLinnhoff there is a precedence error in retrieve_offsets which can lead to errors if the function is called again after a completed read.
This PR fixes this bug and adds a test case to detect such errors.