Skip to content

Conversation

@pmai
Copy link
Contributor

@pmai pmai commented Apr 23, 2021

The v3.3.0 release of OSI has obsolete and wrong VERSION information of 3.2.0. In order to fix this problem we will have to release a v3.3.1 bug fix release with updated VERSION information, which this PR prepares.

A related question is whether we want to include the updated overview documentation in 3.3.1, if we have to do a 3.3.1 anyway.

@pmai pmai added Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Apr 23, 2021
@pmai pmai added this to the V3.3.1 milestone Apr 23, 2021
@pmai pmai requested review from kmeids and stefancyliax April 23, 2021 13:02
@pmai pmai self-assigned this Apr 23, 2021
@stefancyliax
Copy link
Contributor

(There was already a branch vom @caspar-ai regarding this.)

@max-rosin: What do you think? Would it be possible to update the overview documentation in the near term?

Copy link
Contributor

@stefancyliax stefancyliax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stefancyliax
Copy link
Contributor

Missing: new entry in doc/releases/v03.03.rst

Signed-off-by: Stefan Cyliax <[email protected]>
@kmeids
Copy link

kmeids commented Apr 28, 2021

Output CCB 28.04.2021 :

  1. @pmai please remove "In this context, OSI defines generic interfaces to ensure modularity, integrability, and interchangeability of the individual components:" and the following image.
  2. @pmai please release 3.3.1 directly after.

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this PR is ready for a final review and merge by the CCB. labels Apr 28, 2021
Copy link

@kmeids kmeids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from the CCB meeting 28.04.2021

@pmai pmai merged commit ab60959 into master Apr 28, 2021
@pmai pmai deleted the fix/osi-3-3-0-version-wrong branch April 28, 2021 11:40
@stefancyliax stefancyliax linked an issue May 1, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 3.3.0 is still version 3.2.0

4 participants