Reworked Checklist for each PR #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasNaderBMW
force-pushed
the
feature/checklist_3.3.0
branch
from
de39a75 to
141a8a3
Compare
kmeids
reviewed
Feb 5, 2021
.github/pull_request_template.md
Outdated
| - [ ] I have added tests that prove my fix is effective or that my feature works. | ||
| - [ ] New and existing unit tests / travis ci pass locally with my changes. | ||
| If you can’t check all of them, please explain why. | ||
| If all boxes are checked or commented and you achieved at least one positive review, you can assign the label readyForCCB! |
There was a problem hiding this comment.
@ThomasNaderBMW, some minor changes
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!
Contributor
Author
There was a problem hiding this comment.
Thank you for the correction @kmeids ! Of course, totally agree.
kmeids
force-pushed
the
feature/checklist_3.3.0
branch
from
97b9cd8 to
3f66275
Compare
kmeids
added
ReadyForCCBReview
kmeids
approved these changes
Feb 11, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Approved during CCB meeting 11.02.2021
|
Output of CCB meeting 11.02.2021
|
pmai
force-pushed
the
feature/checklist_3.3.0
branch
from
b200ea1 to
c647345
Compare
Signed-off-by: Thomas Nader <[email protected]>
Signed-off-by: Kmeid Saad <[email protected]>
Signed-off-by: Thomas Nader <[email protected]>
pmai
force-pushed
the
feature/checklist_3.3.0
branch
from
c647345 to
c06260d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
None.
Add a description
Checklist reworked as decided in the Q4/2020-Meeting at ASAM (27.01.2021).
Some questions to ask:
What is this change?
The checklist inside each PR to tell how "grown up" your PR is.
I also deleted the "Mention a member"-part as this is done by assigning reviewers (agree on that?)
What does it fix?
PR-Improvement.
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
PR-Improvement.
How has it been tested?
The test is done by this PR.
See the new content from here below:
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you achieved at least one positive review, you can assign the label readyForCCB.