Skip to content

Commit 2e4aace

Browse files
committed
Deprecate various car types in favor of new alias TYPE_CAR
This is a result of the harmonization effort across ASAM Open standards Signed-off-by: Pierre R. Mai <[email protected]>
1 parent 659a95c commit 2e4aace

File tree

1 file changed

+25
-4
lines changed

1 file changed

+25
-4
lines changed

osi_object.proto

Lines changed: 25 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -766,10 +766,12 @@ message MovingObject
766766
// other OpenX standards (in particular, OpenScenario 1.x and 2.x, and OpenLabel).
767767
// This is primarily for historical reasons. Where a single type from a
768768
// different standard can map to multiple OSI types it is left up to the
769-
// discretion of the OSI implementer how that mapping is achieved. For example,
770-
// a simulator may use the dimensions of a provided 3d model of a vehicle with type
771-
// "car" in OpenScenario, to determine whether it should be a TYPE_SMALL_CAR or
772-
// TYPE_MEDIUM_CAR in OSI.
769+
// discretion of the OSI implementer how that mapping is achieved. In previous
770+
// versions, for example, a simulator might have used the dimensions of a provided
771+
// 3d model of a vehicle with type "car" in OpenScenario, to determine whether it
772+
// should be a TYPE_SMALL_CAR or TYPE_MEDIUM_CAR in OSI. As part of the harmonization
773+
// effort, it should now map to TYPE_CAR, which is an alias of the old TYPE_MEDIUM_CAR,
774+
// and all other car type enums have been deprecated in favor of TYPE_CAR.
773775
//
774776
// \note Vehicle type classification is a complex area and there are no
775777
// universally recognized standards. As such, the boundaries between some of the
@@ -780,6 +782,10 @@ message MovingObject
780782
//
781783
enum Type
782784
{
785+
// Allow aliases in enum
786+
//
787+
option allow_alias = true;
788+
783789
// Type of vehicle is unknown (must not be used in ground truth).
784790
//
785791
TYPE_UNKNOWN = 0;
@@ -792,24 +798,39 @@ message MovingObject
792798
//
793799
// Definition: Hatchback car with maximum length 4 m.
794800
//
801+
// \note Deprecated differentiation, use TYPE_CAR instead
802+
//
795803
TYPE_SMALL_CAR = 2;
796804

797805
// Vehicle is a compact car.
798806
//
799807
// Definition: Hatchback car with length between 4 and 4.5 m.
800808
//
809+
// \note Deprecated differentiation, use TYPE_CAR instead
810+
//
801811
TYPE_COMPACT_CAR = 3;
802812

813+
// Vehicle is a car.
814+
//
815+
// This is to be used for all car-like vehicles, without any
816+
// further differentiated type available.
817+
//
818+
TYPE_CAR = 4;
819+
803820
// Vehicle is a medium car.
804821
//
805822
// Definition: Hatchback or sedan with length between 4.5 and 5 m.
806823
//
824+
// \note Deprecated differentiation, use TYPE_CAR instead, which is an alias
825+
//
807826
TYPE_MEDIUM_CAR = 4;
808827

809828
// Vehicle is a luxury car.
810829
//
811830
// Definition: Sedan or coupe that is longer then 5 m.
812831
//
832+
// \note Deprecated differentiation, use TYPE_CAR instead
833+
//
813834
TYPE_LUXURY_CAR = 5;
814835

815836
// Vehicle is a delivery van.

0 commit comments

Comments
 (0)