fix: link to new feature in about section#2698
Merged
ReimarBauer merged 4 commits intoOpen-MSS:stablefrom Mar 18, 2025
Merged
Conversation
ReimarBauer
requested changes
Mar 16, 2025
Member
ReimarBauer
left a comment
ReimarBauer
left a comment
There was a problem hiding this comment.
please fix also the broken test
ReimarBauer
reviewed
Mar 16, 2025
tests/_test_msui/test_msui.py
Outdated
| text = f.read() | ||
| pattern = f'value="is:closed milestone:{__version__[:-1]}"' | ||
| pattern = f'value="is:closed milestone:{__version__}"' | ||
| assert pattern in text.decode('utf-8') |
Member
There was a problem hiding this comment.
the test maybe become later improved. It had not failed with having the bug. But it should.
It would have been better to write a test first which also fails for the bug.
Member
There was a problem hiding this comment.
the test should. not just verify what is on the page
so the tests needs to become improved.
@divyaajainn is that enough information?
Contributor
Author
There was a problem hiding this comment.
yes thank you for the info, i got it
added 2 commits
March 17, 2025 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?: This PR fixes the milestone link in the About section. Previously, the link was incomplete because the milestone version was incorrectly formatted (for example: "9.2." instead of "9.2.0"). This fix ensures that the correct milestone version is used in the link.
Bug fix:
Fixes #2685