Skip to content

fix: update MSUI Help Section#2613

Merged
ReimarBauer merged 6 commits intoOpen-MSS:developfrom
divyaajainn:fix/msui-help-section
Feb 4, 2025
Merged

fix: update MSUI Help Section#2613
ReimarBauer merged 6 commits intoOpen-MSS:developfrom
divyaajainn:fix/msui-help-section

Conversation

@divyaajainn
Copy link
Contributor

@divyaajainn divyaajainn commented Jan 27, 2025

Fixes #2600

Purpose of PR?:

  1. Added Tab in the Help section of MSUI which will have instructions on how to upload a profile picture.
    profile tab

  2. Updated the chat window which now shows profile photo and
    online indicator feature.
    new chat window

@divyaajainn divyaajainn marked this pull request as draft January 27, 2025 17:52
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use similiar to the old images, names which we like to see by a user.

in the previous example, we had also a meaningful conversation.

image

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also not good to add your e-mail address there, this gives some more spam.

When you use as in the old example John Doe, it is constistant with what happens in the chat using this user. And the other users are also in the other pngs.

@ReimarBauer
Copy link
Member

Just seen it is draft, sorry, I was looking already.

@divyaajainn
Copy link
Contributor Author

That's alright! Thank you for the review. I'll make the necessary changes.

@divyaajainn divyaajainn marked this pull request as ready for review January 29, 2025 10:19
@ReimarBauer
Copy link
Member

it looks like ui_mscolab_help_dialog.py was edited manually. In case you did, there are linting failures which usually is avoided by pyuic5 --from-imports

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name upload-profile is a bit misleading it is more like add-profile-image
you do describe the action

@ReimarBauer
Copy link
Member

while looking on the chat picture again now I realized, that the role admin is a bit too often there. creator can give admin role to someone to add users with roles. commonly we have more with the collaborator role than with admin.
admin role has also all collaborator options. So it is not wrong.

@divyaajainn
Copy link
Contributor Author

divyaajainn commented Jan 30, 2025

the flake8/white-space issue was in the ui_mscolab_help_dialog.py file (an empty line at the end of the file) but couldn't remove it as it would've lead to other linting failures. Please let me know if there's a way to do it without manually changing the file.

@ReimarBauer
Copy link
Member

I can reproduce the problem with the trailing whitespace in your branch for ui_mscolab_help_dialog.ui when saving the file by the designer it happens also for me.

when I once manually reformat the lines like:

@@ -340,11 +339,7 @@ p, li { white-space: pre-wrap; }
                </property>
               </spacer>
              </item>
-            </layout>
-           </item> 
-          </layout> 
-         </item>  
-        </layout>
+            </layout></item></layout></item></layout>
        </widget>

and save it by the designer again it shows up again. Please disable it for now in the scan https://github.com/Open-MSS/MSS/blob/develop/.github/workflows/lint.yml#L70

@divyaajainn
Copy link
Contributor Author

Temporarily disabled the check as suggested.

@divyaajainn divyaajainn force-pushed the fix/msui-help-section branch from 1a5a604 to ef805b4 Compare February 3, 2025 08:59
@divyaajainn
Copy link
Contributor Author

divyaajainn commented Feb 3, 2025

still failing the no-white-space check after excluding ui_mscolab_help_dialog.py and ui_mscolab_help_dialog.ui file from linting test. I think it might be due to GitHub catching old results from cache OR the workflow might not trigger a new run because it thinks nothing has changed OR line: 344,345,346 in ui_mscolab_help_dialog.ui is showing this error and can be fixed manually and recompiled. or maybe I didn't disable it correctly. What would you prefer me to do?

@ReimarBauer
Copy link
Member

ReimarBauer commented Feb 3, 2025

still failing the no-white-space check after excluding ui_mscolab_help_dialog.py and ui_mscolab_help_dialog.ui file from linting test. I think it might be due to GitHub catching old results from cache OR the workflow might not trigger a new run because it thinks nothing has changed OR line: 344,345,346 in ui_mscolab_help_dialog.ui is showing this error and can be fixed manually and recompiled. or maybe I didn't disable it correctly. What would you prefer me to do?

you need to use the relative path and only for the ui file, there are 2 examples in the line. take this as example.
:^tests/data/example.txt :^docs/samples/flight-tracks/example.txt

@divyaajainn divyaajainn force-pushed the fix/msui-help-section branch from 7f764fa to ef805b4 Compare February 3, 2025 10:04
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@ReimarBauer ReimarBauer merged commit d37c2a9 into Open-MSS:develop Feb 4, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve/Update MSUI Help Section

2 participants