fix: update MSUI Help Section#2613
Conversation
|
Just seen it is draft, sorry, I was looking already. |
|
That's alright! Thank you for the review. I'll make the necessary changes. |
|
it looks like ui_mscolab_help_dialog.py was edited manually. In case you did, there are linting failures which usually is avoided by |
ReimarBauer
left a comment
There was a problem hiding this comment.
the name upload-profile is a bit misleading it is more like add-profile-image
you do describe the action
|
while looking on the chat picture again now I realized, that the role admin is a bit too often there. creator can give admin role to someone to add users with roles. commonly we have more with the collaborator role than with admin. |
|
the flake8/white-space issue was in the ui_mscolab_help_dialog.py file (an empty line at the end of the file) but couldn't remove it as it would've lead to other linting failures. Please let me know if there's a way to do it without manually changing the file. |
|
I can reproduce the problem with the trailing whitespace in your branch for ui_mscolab_help_dialog.ui when saving the file by the designer it happens also for me. when I once manually reformat the lines like: and save it by the designer again it shows up again. Please disable it for now in the scan https://github.com/Open-MSS/MSS/blob/develop/.github/workflows/lint.yml#L70 |
|
Temporarily disabled the check as suggested. |
1a5a604 to
ef805b4
Compare
|
still failing the no-white-space check after excluding ui_mscolab_help_dialog.py and ui_mscolab_help_dialog.ui file from linting test. I think it might be due to GitHub catching old results from cache OR the workflow might not trigger a new run because it thinks nothing has changed OR line: 344,345,346 in ui_mscolab_help_dialog.ui is showing this error and can be fixed manually and recompiled. or maybe I didn't disable it correctly. What would you prefer me to do? |
you need to use the relative path and only for the ui file, there are 2 examples in the line. take this as example. |
7f764fa to
ef805b4
Compare

Fixes #2600
Purpose of PR?:
Added Tab in the Help section of MSUI which will have instructions on how to upload a profile picture.

Updated the chat window which now shows profile photo and

online indicator feature.