Autoplot show message when not used correctly#2557
Closed
ReimarBauer wants to merge 2 commits intoGSOC2024-rebased-autoplotfrom
Closed
Autoplot show message when not used correctly#2557ReimarBauer wants to merge 2 commits intoGSOC2024-rebased-autoplotfrom
ReimarBauer wants to merge 2 commits intoGSOC2024-rebased-autoplotfrom
Conversation
Member
Author
|
Some of the other changes changed the behaviour, it did not crash |
Member
Author
|
I assume thats the better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Avoid a crash when a mssautoplot.json file is loaded before the corresponding operations or fligt tracks are added to MSUI.
You can try this on a fresh start of msui, loading topview, autoplot, selecting mssautoplot.json, clicking on an entry.
The data in the tree widget gets now reduced to those matching in the interface. The crash of requesting WMS data before get_capabilties is catched too. In a future vesion it should be possible to call get_capabilties on loading the mssautoplot.json.