reorder imports in autoplot_dockwidget#2555
Merged
ReimarBauer merged 2 commits intoOpen-MSS:GSOC2024-rebased-autoplotfrom Oct 6, 2024
Merged
reorder imports in autoplot_dockwidget#2555ReimarBauer merged 2 commits intoOpen-MSS:GSOC2024-rebased-autoplotfrom
ReimarBauer merged 2 commits intoOpen-MSS:GSOC2024-rebased-autoplotfrom
Conversation
ReimarBauer
reviewed
Oct 6, 2024
mslib/msui/autoplot_dockwidget.py
Outdated
|
|
||
| from PyQt5.QtWidgets import QWidget, QFileDialog, QTreeWidgetItem, QMessageBox | ||
| from PyQt5 import QtCore | ||
| import click |
Member
There was a problem hiding this comment.
move this before the first from PyQt5 import then we have all from after each other. both are also not in the standardlib
ReimarBauer
requested changes
Oct 6, 2024
Member
ReimarBauer
left a comment
There was a problem hiding this comment.
one import has a name problem, because the cli_tool was renamed back to main.
Member
|
maybe do this also for mslib.utils.mssautoplot, there e.g. requests needs to become separately installed is not in stdlib. |
ReimarBauer
approved these changes
Oct 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
reorder imports in autoplot_dockwidget
Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>