Skip to content

fix test for github milestone_url #2816

@ReimarBauer

Description

@ReimarBauer

The current test checks for closed issues matching a version in the URL search string (e.g., https://github.com/Open-MSS/MSS/issues?q=is%3Aclosed+milestone%3A10.0.1). This approach incorrectly returns ‘True’ even if the version doesn't exist.

Instead, we could verify a release exists by checking for a 200 status code when requesting its tag (e.g., https://github.com/Open-MSS/MSS/releases/tag/10.1.0). That fails because the version string is updated before the corresponding tag is created.

I think we should remove the test.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtests

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions