feat: Add support for generic oidc accounts #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grace-rehn
commented
Dec 2, 2024
go.mod
Outdated
| github.com/MakeNowJust/heredoc/v2 v2.0.1 | ||
| github.com/OctopusDeploy/go-octodiff v1.0.0 | ||
| github.com/OctopusDeploy/go-octopusdeploy/v2 v2.59.0 | ||
| github.com/OctopusDeploy/go-octopusdeploy/v2 v2.62.3-0.20241202024636-075a4f06c227 |
Contributor
Author
There was a problem hiding this comment.
Use OctopusDeploy/go-octopusdeploy#288 for now.
Will update with the correct version once go client is merged after octopus server changes.
benPearce1
reviewed
Dec 2, 2024
| link := output.Bluef("%s/app#/%s/infrastructure/accounts/%s", opts.Host, opts.Space.GetID(), createdAccount.GetID()) | ||
| fmt.Fprintf(opts.Out, "\nView this account on Octopus Deploy: %s\n", link) | ||
| if !opts.NoPrompt { | ||
| autoCmd := flag.GenerateAutomationCmd( |
Contributor
There was a problem hiding this comment.
Looks like Audience is missing from the automation command output
benPearce1
approved these changes
Dec 2, 2024
Contributor
benPearce1
left a comment
benPearce1
left a comment
There was a problem hiding this comment.
LGTM, one comment about the Audience option missing from the automation command output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
octopus account generic-oidcoctopus account generic-oidc listoctopus account generic-oidc create[sc-98285]