grass.script: Add Python type hints to core.py#7130
Merged
echoix merged 1 commit intoOSGeo:mainfrom Mar 3, 2026
Merged
Conversation
Sourish-spc
changed the title
echoix
approved these changes
Mar 3, 2026
Dasux
pushed a commit
to Dasux/grass
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a small housekeeping contribution to modernize the Python API by adding missing type hints to several utility functions in
grass.script.core.Changes made:
-> booltooverwrite()-> inttoverbosity()s: strand-> booltolegal_name(s)These changes improve static analysis and IDE autocomplete support without altering any underlying logic.
Motivation and Context
As part of preparing for GSoC 2026, I am exploring the GRASS GIS codebase. While reviewing the Python API, I noticed that while some functions (like
parser()) have been updated with modern type hints, several utility functions at the bottom ofcore.pyhave not yet been transitioned.How Has This Been Tested?
These are strictly non-functional type hint additions. The code has been reviewed to ensure no runtime logic is modified.