fix test cases.

Author: BhaveshHeliconia

stock_lot_multi_image/tests/test_stock_lot_multi_image.py

@@ -7,10 +7,34 @@
 
 
 class TestStockLotMultiImage(BaseCommon):
+    @classmethod
+    def _get_image_vals(cls, name, image_data):
+        """Helper to get image values based on available fields"""
+        comodel = cls.env["stock.lot"]._fields["image_ids"].comodel_name
+        fields_list = cls.env[comodel]._fields
+        vals = {"name": name}
+        if "storage" in fields_list:
+            vals["storage"] = "filestore"
+        if "attachment_image" in fields_list:
+            vals["attachment_image"] = image_data
+        elif "image_1920" in fields_list:
+            vals["image_1920"] = image_data
+        if "owner_model" in fields_list:
+            vals["owner_model"] = "stock.lot"
+        return vals
+
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
 
+        # Neutralize invalid domain on image_ids if conflict with stock_lot_image exists
+        field = cls.env["stock.lot"]._fields["image_ids"]
+        comodel_fields = cls.env[field.comodel_name]._fields
+        if "owner_model" not in comodel_fields:
+            # If the domain refers to owner_model, we must clear it to avoid KeyError
+            # in filtered_domain during record creation/linking.
+            field.domain = []
+
         # Create test images
         cls.transparent_image = (  # 1x1 Transparent GIF
             b"R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7"
@@ -38,21 +62,9 @@ def setUpClass(cls):
                 "company_id": cls.env.company.id,
                 "image_ids": [
                     Command.create(
-                        {
-                            "storage": "filestore",
-                            "name": "Image 1",
-                            "attachment_image": cls.transparent_image,
-                            "owner_model": "stock.lot",
-                        }
-                    ),
-                    Command.create(
-                        {
-                            "storage": "filestore",
-                            "name": "Image 2",
-                            "attachment_image": cls.black_image,
-                            "owner_model": "stock.lot",
-                        }
+                        cls._get_image_vals("Image 1", cls.transparent_image)
                     ),
+                    Command.create(cls._get_image_vals("Image 2", cls.black_image)),
                 ],
             }
         )
@@ -77,14 +89,7 @@ def test_add_image(self):
         self.test_lot.write(
             {
                 "image_ids": [
-                    Command.create(
-                        {
-                            "storage": "filestore",
-                            "attachment_image": self.grey_image,
-                            "name": "Image 3",
-                            "owner_model": "stock.lot",
-                        }
-                    )
+                    Command.create(self._get_image_vals("Image 3", self.grey_image))
                 ]
             }
         )