buildMultiTargeting unintentionally makes a package compatible with every framework

[Varorbc]

NuGet Product Used

dotnet.exe

Product Version

9.0.300

Worked before?

No response

Impact

None

Repro Steps & Context

The target frameworks supported by Microsoft.NET.Test.Sdk are net8.0 and net462, and the target framework of my project is net6.0. When building, the warning of nu1701 should be generated, but there is no warning now.

1.dotnet new console -f net6.0 -n Test
2.dotnet add package Microsoft.NET.Test.Sdk --version 17.14.0
3.dotnet build

Verbose Logs

[jebriede]

I was able to reproduce the issue with the repro steps:
info : Package 'Microsoft.NET.Test.Sdk' is compatible with all the specified frameworks in project 'Test\Test.csproj'.

[nkolev92]

Technically this is expected, https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Core/NuGet.Commands/RestoreCommand/CompatibilityChecker.cs#L362C1-L363C1.

Basically, the props file in buildMultiTargeting makes the package compatible with every framework.

That being said, I don't love this because it effectively means anytime you need your package to have something that's outer build specific, it just makes it compatible with every framework.

[nkolev92]

Team Triage: We'll leave this as open and retitle, but changing this is a likely breaking change, albeit something we can estimate by analyzing all of the packages on NuGet.org.

[Varorbc]

I still have one issue. Why did I receive a warning from NU1701 when I merely modified the package name of Microsoft.NET.Test.Sdk, uploaded it to the private source, and then installed it?

[nkolev92]

Please upload the package somewhere we can access it so we can take a look.
Providing us the project would help too.

[Varorbc]

@nkolev92 microsoft.net.test.sdk1.17.14.0.zip