improve testFail* deprecation warning handling

Author: iosh

v-next/hardhat/src/internal/builtin-plugins/solidity-test/helpers.ts

@@ -149,7 +149,7 @@ export function warnDeprecatedTestFail(
         artifact.id,
         sourceNameToUserSourceName,
       );
-      const warningMessage = `${colorizer.yellow("Warning")}: ${name} Tests name \`testFail*\` has been removed. Consider changing to \`vm.expectRevert()\` for testing reverts in ${formattedLocation}\n`;
+      const warningMessage = `${colorizer.yellow("Warning")}: ${name} The support for the prefix \`testFail*\` has been removed. Consider using \`vm.expectRevert()\` for testing reverts in ${formattedLocation}\n`;
 
       console.warn(warningMessage);
     }

v-next/hardhat/src/internal/builtin-plugins/solidity-test/task-action.ts

@@ -112,21 +112,25 @@ const runSolidityTests: NewTaskActionFunction<TestActionArguments> = async (
     ]),
   );
 
-  const testSuiteArtifacts = edrArtifacts
+  edrArtifacts.forEach(({ userSourceName, edrAtifact }) => {
+    if (
+      rootFilePaths.includes(
+        resolveFromRoot(hre.config.paths.root, userSourceName),
+      ) &&
+      isTestSuiteArtifact(edrAtifact)
+    ) {
+      warnDeprecatedTestFail(edrAtifact, sourceNameToUserSourceName);
+    }
+  });
+
+  const testSuiteIds = edrArtifacts
     .filter(({ userSourceName }) =>
       rootFilePaths.includes(
         resolveFromRoot(hre.config.paths.root, userSourceName),
       ),
     )
-    .filter(({ edrAtifact }) => isTestSuiteArtifact(edrAtifact));
-
-  testSuiteArtifacts.forEach(({ edrAtifact }) => {
-    warnDeprecatedTestFail(edrAtifact, sourceNameToUserSourceName);
-  });
-
-  const testSuiteIds = testSuiteArtifacts.map(
-    ({ edrAtifact }) => edrAtifact.id,
-  );
+    .filter(({ edrAtifact }) => isTestSuiteArtifact(edrAtifact))
+    .map(({ edrAtifact }) => edrAtifact.id);
 
   console.log("Running Solidity tests");
   console.log();