Skip to content

Commit 4d6b9ab

Browse files
authored
feat: added spellcheck workflow for checking spelling (main) (#6955)
* feat: added spellcheck workflow for checking spelling * chore: fix spelling mistakes * chore: update cspell.yml * chore: bring back buidler * chore: bring back buidler (v2) * chore: fix a few more cspell issues * chore: prettier * chore: renames * chore: rename fixture projects * chore: update ignition test fixtures
1 parent 69acece commit 4d6b9ab

File tree

115 files changed

+293
-265
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

115 files changed

+293
-265
lines changed

.github/workflows/spellcheck.yml

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
name: Check Spelling
2+
3+
on:
4+
push:
5+
branches:
6+
- main
7+
- v-next
8+
pull_request:
9+
workflow_dispatch:
10+
11+
jobs:
12+
spellcheck:
13+
runs-on: ubuntu-latest
14+
steps:
15+
- uses: actions/checkout@v4
16+
17+
# TODO: Replace with https://github.com/streetsidesoftware/cspell-action
18+
# once it supports the `report` input
19+
- uses: galargh/cspell-action@report
20+
with:
21+
incremental_files_only: ${{ github.event_name == 'pull_request' }}
22+
config: cspell.yaml
23+
report: typos

cspell.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
ignorePaths:
2+
- pnpm-lock.yaml
3+
ignoreWords:
4+
- buidler
5+
- Saty248

e2e/fixture-projects/clean/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ echo "it should run the command clean successfully"
2020
run_test_and_handle_failure "npx hardhat clean" 0
2121

2222
echo "it should have deleted the artifacts directory and emptied the cache directory"
23-
assert_directory_doesnt_exist "artifacts"
23+
assert_directory_does_not_exist "artifacts"
2424
assert_directory_exists "cache"
2525
assert_directory_empty "cache"

e2e/fixture-projects/vars/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ echo "it should fail because the key does not exist"
2222
run_test_and_handle_failure "npx hardhat vars get HH_KEY_DO_NOT_EXIST_3468267" 1
2323

2424
#
25-
# Do not DELETE or SET keys to avoid modifing the configuration variables of the user running these tests
25+
# Do not DELETE or SET keys to avoid modifying the configuration variables of the user running these tests
2626
#

e2e/helpers.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ assert_directory_exists() {
3838
fi
3939
}
4040

41-
assert_directory_doesnt_exist() {
41+
assert_directory_does_not_exist() {
4242
if [ -d "$1" ]; then
4343
echo "Expected directory $1 to not exist, but it does"
4444
exit 1

packages/hardhat-chai-matchers/src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function buildNormal(ssfi: Ssfi) {
4949
* this value should be captured at the beginning of the matcher's
5050
* implementation, before any async code is executed. Otherwise things like
5151
* `.to.emit().and.not.to.emit()` won't work, because by the time the async part
52-
* of the first emit is executd, the `.not` (executed synchronously) has already
52+
* of the first emit is executed, the `.not` (executed synchronously) has already
5353
* modified the flag.
5454
*
5555
* The second parameter is what Chai calls the "start stack function indicator",

packages/hardhat-core/CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@
159159
- cdf0160: Upgrade bundled solcjs
160160
- 3c66da2: Add support for Node v22
161161
- 9fadc22: Bump EDR to [v0.4.1](https://github.com/NomicFoundation/edr/releases/tag/%40nomicfoundation%2Fedr%400.4.1).
162-
- 095faa4: Added hardfork histories for Optimim and Arbitrum chains
162+
- 095faa4: Added hardfork histories for Optimism and Arbitrum chains
163163

164164
## 2.22.5
165165

@@ -482,7 +482,7 @@
482482
- c9809e182: Trim leading and trailing spaces in mnemonics.
483483
- a1d43109a: Pending blocks now include the `bloom` field.
484484
- 818107821: Added a new `hardhat_metadata` RPC method
485-
- 937d15e51: A better error is show if a Solidity file makes an import throug its own package name.
485+
- 937d15e51: A better error is show if a Solidity file makes an import through its own package name.
486486
- 4cf9a6d58: Added a `getBuildInfoSync` function to the `hre.artifacts` object (thanks @emretepedev!)
487487

488488
## 2.12.2
@@ -713,7 +713,7 @@
713713
### Patch Changes
714714

715715
- 99c17f43: Bump uuid package to remove a deprecation warning (thanks @yhuard!)
716-
- 8076c43b: Fixed how the cummulative gas is computed for receipts and added a missing field (Thanks @ngotchac!)
716+
- 8076c43b: Fixed how the cumulative gas is computed for receipts and added a missing field (Thanks @ngotchac!)
717717
- e6362902: Display similar artifact names in error output if given name is not found (#201)
718718
- e087bd0b: Improve validation of private keys in the Hardhat config
719719
- aa1a0080: Fix an issue with new versions of Node.js that prevented clients from connecting to Hardhat's node using 127.0.0.1

packages/hardhat-core/src/builtin-tasks/compile.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1113,7 +1113,7 @@ subtask(TASK_COMPILE_SOLIDITY_GET_COMPILATION_JOBS_FAILURE_REASONS)
11131113
compilationJobsCreationErrors: CompilationJobCreationError[];
11141114
}): Promise<string> => {
11151115
const noCompatibleSolc: CompilationJobCreationError[] = [];
1116-
const incompatibleOverridenSolc: CompilationJobCreationError[] = [];
1116+
const incompatibleOverriddenSolc: CompilationJobCreationError[] = [];
11171117
const directlyImportsIncompatibleFile: CompilationJobCreationError[] = [];
11181118
const indirectlyImportsIncompatibleFile: CompilationJobCreationError[] =
11191119
[];
@@ -1127,9 +1127,9 @@ subtask(TASK_COMPILE_SOLIDITY_GET_COMPILATION_JOBS_FAILURE_REASONS)
11271127
noCompatibleSolc.push(error);
11281128
} else if (
11291129
error.reason ===
1130-
CompilationJobCreationErrorReason.INCOMPATIBLE_OVERRIDEN_SOLC_VERSION
1130+
CompilationJobCreationErrorReason.INCOMPATIBLE_OVERRIDDEN_SOLC_VERSION
11311131
) {
1132-
incompatibleOverridenSolc.push(error);
1132+
incompatibleOverriddenSolc.push(error);
11331133
} else if (
11341134
error.reason ===
11351135
CompilationJobCreationErrorReason.DIRECTLY_IMPORTS_INCOMPATIBLE_FILE
@@ -1151,12 +1151,12 @@ subtask(TASK_COMPILE_SOLIDITY_GET_COMPILATION_JOBS_FAILURE_REASONS)
11511151
}
11521152

11531153
let errorMessage = "";
1154-
if (incompatibleOverridenSolc.length > 0) {
1154+
if (incompatibleOverriddenSolc.length > 0) {
11551155
errorMessage += `The compiler version for the following files is fixed through an override in your config file to a version that is incompatible with their Solidity version pragmas.
11561156
11571157
`;
11581158

1159-
for (const error of incompatibleOverridenSolc) {
1159+
for (const error of incompatibleOverriddenSolc) {
11601160
const { sourceName } = error.file;
11611161
const { versionPragmas } = error.file.content;
11621162
const versionsRange = versionPragmas.join(" ");

packages/hardhat-core/src/builtin-tasks/test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import {
1313
isTypescriptFile,
1414
} from "../internal/core/typescript-support";
1515
import { getForkCacheDirPath } from "../internal/hardhat-network/provider/utils/disk-cache";
16-
import { showForkRecommendationsBannerIfNecessary } from "../internal/hardhat-network/provider/utils/fork-recomendations-banner";
16+
import { showForkRecommendationsBannerIfNecessary } from "../internal/hardhat-network/provider/utils/fork-recommendations-banner";
1717
import { pluralize } from "../internal/util/strings";
1818
import { getAllFilesMatching } from "../internal/util/fs-utils";
1919
import { getProjectPackageJson } from "../internal/util/packageInfo";

packages/hardhat-core/src/internal/core/providers/errors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { CustomError } from "../errors";
1717
//
1818
// Non standard:
1919

20-
// -32999 Invalid response The server returned a JSON-RPC hardhat-sepecific
20+
// -32999 Invalid response The server returned a JSON-RPC hardhat-specific
2121
// response, but the result is not
2222
// in the expected format
2323
//

0 commit comments

Comments
 (0)