-
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
djangorestframework-jwt: init at 1.11.0 #53698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dotlambda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding yourself to maintainer-list.nix should be a separate commit.
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
|
Btw, did you read https://nixos.org/nixpkgs/manual/#python? |
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
|
@dotlambda Yes, I've read the python manual. |
dotlambda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding django-rest-auth without referencing it in python-packages.nix?
Also, please make sure the commit which adds you to the maintainer list is the first one.
pkgs/development/python-modules/djangorestframework-jwt/default.nix
Outdated
Show resolved
Hide resolved
|
@dotlambda I accidentally added the |
If it makes sense to, e.g. if these are all required for a certain package you're packaging, you should put these commits in a single PR. |
|
I'll close this and open a second PR later on with all the other modules I'll need. |
|
Please ping me when you did so. |
|
@dotlambda I have a package that doesn't include tests in the pypi release, is it a better practice to package the testless pypi or the github release that includes tests? |
|
If you plan on actively maintaining it, I think there's no harm in fetching from GitHub. Otherwise, PyPI is preferred because it allows for auto-upgrades. Best would be to file an upstream PR or issue so they include the tests in their PyPI tarball. |
Motivation for this change
I'm packaging this python library because I want to use nix-shell to manage python dependencies for a project.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)