prettier: Use wrapProgram for plugins
#442463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
l0b0
reviewed
Sep 13, 2025
These changes _should_ be backwards compatible while allowing users to opt-in to declaring list of Prettier `plugins` via `.override` High-level summary; - Add `plugins` package level argument - Add `exportRelativePathOf` and `nodeEntryPointOf` internal functions - Inject `wrapProgram` into `installPhase` Attributions; - `l0b0` much thanks for code and doc review
S0AndS0
force-pushed
the
prettier-with-plugins
branch
from
9882f8f to
6236e8b
Compare
Member
Author
|
Thanks for the rapid review @l0b0! I've applied the corrections, and tested things still build (and work) on my device, as well as squashed things down to a single commit 🎉 Please do let me know if there be anything else that'll prevent proposed changes from being acceptable :-) |
nixpkgs-ci
bot
added
12.approvals: 1
Member
Author
|
Ah that, "after a week", tip be super helpful for me not violating social norms around these parts x-) I'll set a reminder for myself to check-in later as |
S0AndS0
added a commit
to S0AndS0/nixpkgs
that referenced
this pull request
Sep 14, 2025
Main intent is to provide Prettier plugins for PR NixOS#442463 to consume. Prettier provides, at time of this commit, four [official](https://prettier.io/docs/plugins/#official-plugins) plugins. And there are about two dozen [community](https://prettier.io/docs/plugins/#community-plugins) plugins available too. So it seems wise to leverage existing code, where possible, and follow examples provided by similar NPM projects that have been packaged with plugins. Much of these changes are based on examples found from; - `./pkgs/by-name/le/lessc/plugins/` - `./pkgs/development/node-packages/` ... as well as documentation provided in; - `./doc/languages-frameworks/javascript.section.md`
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should be backwards compatible while allowing users to opt-in to declaring list of Prettier
pluginsvia.overrideDoc-comments hopefully'll provide sufficient details about what the added features/functions are intended to do.
High-level summary;
pluginspackage level argumentexportRelativePathOfandnodeEntryPointOfinternal functionswrapProgramintoinstallPhaseLimitations;
<plugin>imported fromnoop.jsshows though we can add--plugin=<path>to CLI viawrapProgramthere are upstream limitations due to how they doimport/requirepath discoverynodeExportAttrAddresses... also that list's order is kinda brittle--plugin=<path>that can be injected, while still allowing users to define other parameters, but unlikely it is that limit will be reachedThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.