Added iconField #221
Open
Added iconField #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajohnson89
reviewed
Jun 25, 2020
| export class ListItem { | ||
| id: String | number; | ||
| text: String | number; | ||
| icon: String; |
There was a problem hiding this comment.
This would need to be an optional parameter as not everyone would use an icon.
lajohnson89
reviewed
Jun 25, 2020
| <li *ngFor="let item of _data | multiSelectFilter:filter; let i = index;" (click)="onItemClick($event,item)" class="multiselect-item-checkbox"> | ||
| <input type="checkbox" aria-label="multiselect-item" [checked]="isSelected(item)" [disabled]="disabled || (isLimitSelectionReached() && !isSelected(item)) || item.isDisabled" /> | ||
| <div>{{item.text}}</div> | ||
| <div><i class="{{item.icon}}"></i> {{item.text}}</div> |
There was a problem hiding this comment.
Anything related to icons would need to be tested first. You have modified the code as if 100% of users would consume this property. It would be an optional property.
<i *ngIf="item?.icon" class="{{item.icon}}">
lajohnson89
reviewed
Jun 25, 2020
| ]; | ||
| this.selectedItems = [ | ||
| { item_id: 4, item_text: 'Pune', item_icon: 'fa fa-truck' }, | ||
| { item_id: 6, item_text: 'Navsari', item_icon: 'fa fa-wifi' } |
There was a problem hiding this comment.
The existing code should be unbothered. This would need to be refactored to not touch existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please accepts my pull request to added iconField.
Fixed for issue: #215