Use blib2to3 parser from black package to support match statement
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The built-in lib2to3 does not support pattern matching (Python 3.10+): https://docs.python.org/3.11/library/2to3.html#module-lib2to3 The [black][] project managed to get some level of parsing support for `match` out of their modified version `blib2to3`, see: 1. psf/black#2242 2. psf/black#2586 [black]: https://github.com/psf/black This change adds `black` as a dependency and switches to using `blib2to3` to parse. Tests pass, but that's all that's been attempted thus far.
Owner
|
Thanks a lot for this @nrser 🙌 I hope I can take a closer look later this week.
|
Owner
|
The Thanks a lot for this @nrser! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to issue #79.
The built-in lib2to3 does not support pattern matching (Python 3.10+):
https://docs.python.org/3.11/library/2to3.html#module-lib2to3
The black project managed to get some level of parsing support for
matchout of their modified versionblib2to3, see:This change adds
blackas a dependency and switches to usingblib2to3to parse.Tests pass, and I am currently using it on an actual project of moderate complexity, but this is a significant change to core functionality... caution is advised. It seems like
blib2to3itself is a bit of hack/stop-gap, and that's not counting my hasty integration withdocspec-python.However, for users now in a broken state due to
matchsyntax in their source files this may be worth a shot.