refactor(app): remove unnecessary app fields (#2270)

* remove transient key from app

* remove memKeys from app

* remove privateKeepers

* Update CHANGELOG.md

Author: k-yang

CHANGELOG.md

@@ -40,6 +40,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+- [#2270](https://github.com/NibiruChain/nibiru/pull/2270) - refactor(app): remove private keeper struct and transient/mem keys from app
+
 ## v2.3.0
 
 - [#2242](https://github.com/NibiruChain/nibiru/pull/2242) - feat(tokenfactory): tx msg SudoSetDenomMetadata

app/app.go

@@ -201,9 +201,7 @@ type NibiruApp struct {
 
 	// keys to access the substores
 	// TODO(k-yang): remove once depinject is fully integrated
-	keys    map[string]*storetypes.KVStoreKey
-	tkeys   map[string]*storetypes.TransientStoreKey
-	memKeys map[string]*storetypes.MemoryStoreKey
+	keys map[string]*storetypes.KVStoreKey
 
 	AppKeepers // embed all module keepers
 
@@ -546,20 +544,6 @@ func (app *NibiruApp) GetKey(storeKey string) *storetypes.KVStoreKey {
 	return app.keys[storeKey]
 }
 
-// GetTKey returns the TransientStoreKey for the provided store key.
-//
-// NOTE: This is solely to be used for testing purposes.
-func (app *NibiruApp) GetTKey(storeKey string) *storetypes.TransientStoreKey {
-	return app.tkeys[storeKey]
-}
-
-// GetMemKey returns the MemStoreKey for the provided mem key.
-//
-// NOTE: This is solely used for testing purposes.
-func (app *NibiruApp) GetMemKey(storeKey string) *storetypes.MemoryStoreKey {
-	return app.memKeys[storeKey]
-}
-
 func (app *NibiruApp) kvStoreKeys() map[string]*storetypes.KVStoreKey {
 	keys := make(map[string]*storetypes.KVStoreKey)
 	for _, k := range app.GetStoreKeys() {

app/keepers.go

@@ -69,10 +69,7 @@ const wasmVmContractMemoryLimit = 32
 
 type AppKeepers struct {
 	keepers.PublicKeepers
-	privateKeepers
-}
 
-type privateKeepers struct {
 	capabilityKeeper *capabilitykeeper.Keeper
 	slashingKeeper   slashingkeeper.Keeper
 	crisisKeeper     *crisiskeeper.Keeper