Avoid boxing in Measurment.hashCode

Use Long.hashCode / Double.hashCode to avoid boxing in Measurment.hashCode.

Author: kilink

spectator-api/src/main/java/com/netflix/spectator/api/Measurement.java

@@ -63,8 +63,8 @@ public int hashCode() {
     final int prime = 31;
     int hc = prime;
     hc = prime * hc + id.hashCode();
-    hc = prime * hc + Long.valueOf(timestamp).hashCode();
-    hc = prime * hc + Double.valueOf(value).hashCode();
+    hc = prime * hc + Long.hashCode(timestamp);
+    hc = prime * hc + Double.hashCode(value);
     return hc;
   }
 

spectator-reg-metrics5/src/test/java/com/netflix/spectator/metrics5/MetricsRegistryTest.java

@@ -15,7 +15,6 @@
  */
 package com.netflix.spectator.metrics5;
 
-import io.dropwizard.metrics5.Gauge;
 import io.dropwizard.metrics5.MetricName;
 import io.dropwizard.metrics5.MetricRegistry;
 import com.netflix.spectator.api.ManualClock;
@@ -24,7 +23,11 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-import java.util.*;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicInteger;
 
@@ -49,31 +52,31 @@ public void counter() {
     MetricRegistry dwRegistry = new MetricRegistry();
     MetricsRegistry r = new MetricsRegistry(clock, dwRegistry);
     r.counter("foo").increment();
-    Assertions.assertEquals(1, dwRegistry.getMeters().get(new MetricName("foo", Collections.EMPTY_MAP)).getCount());
+    Assertions.assertEquals(1, dwRegistry.getMeters().get(new MetricName("foo", Collections.emptyMap())).getCount());
     r.counter("foo").increment(15);
-    Assertions.assertEquals(16, dwRegistry.getMeters().get(new MetricName("foo", Collections.EMPTY_MAP)).getCount());
+    Assertions.assertEquals(16, dwRegistry.getMeters().get(new MetricName("foo", Collections.emptyMap())).getCount());
   }
 
   @Test
   public void timer() {
     MetricRegistry dwRegistry = new MetricRegistry();
     MetricsRegistry r = new MetricsRegistry(clock, dwRegistry);
     r.timer("foo").record(1, TimeUnit.MILLISECONDS);
-    Assertions.assertEquals(1, dwRegistry.getTimers().get(new MetricName("foo", Collections.EMPTY_MAP)).getCount());
+    Assertions.assertEquals(1, dwRegistry.getTimers().get(new MetricName("foo", Collections.emptyMap())).getCount());
   }
 
   @Test
   public void distributionSummary() {
     MetricRegistry dwRegistry = new MetricRegistry();
     MetricsRegistry r = new MetricsRegistry(clock, dwRegistry);
     r.distributionSummary("foo").record(1);
-    Assertions.assertEquals(1, dwRegistry.getHistograms().get(new MetricName("foo", Collections.EMPTY_MAP)).getCount());
+    Assertions.assertEquals(1, dwRegistry.getHistograms().get(new MetricName("foo", Collections.emptyMap())).getCount());
   }
 
   private void assertGaugeValue(
       MetricsRegistry r, MetricRegistry dwRegistry, String name, double expected) {
     PolledMeter.update(r);
-    Assertions.assertEquals(expected, (Double) dwRegistry.getGauges().get(new MetricName(name, Collections.EMPTY_MAP)).getValue(), 1e-12);
+    Assertions.assertEquals(expected, (Double) dwRegistry.getGauges().get(new MetricName(name, Collections.emptyMap())).getValue(), 1e-12);
   }
 
   @Test
@@ -123,7 +126,7 @@ public void gaugeRegisteredDirectly() throws Exception {
     AtomicInteger num = r.gauge("foo", new AtomicInteger(42));
 
     // Should be registered with the Dropwizard registry
-    Assertions.assertEquals(42.0, (Double) dwRegistry.getGauges().get(new MetricName("foo", Collections.EMPTY_MAP)).getValue(), 1e-12);
+    Assertions.assertEquals(42.0, (Double) dwRegistry.getGauges().get(new MetricName("foo", Collections.emptyMap())).getValue(), 1e-12);
 
     // Should not be registered with spectator
     Assertions.assertNull(r.get(r.createId("foo")));